Problem/Motivation

If we can make a 3.1.1 release, this module will be D11 compatible and recent bug fixes will be available.

Examining the repo graph, commits for the following issues have been made since the 3.1.0 tag:

These are all bug fixes or deprecations and not new features. That should qualify as a patch release. The last pipeline shows a phpcs error.

Proposed resolution

Get tests passing on 3.x and make a patch release to release these six issues that are fixed.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork views_url_alias-3549850

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fathershawn created an issue. See original summary.

fathershawn opened merge request !36

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Title: [Plan] Getting to a 3.1.1 release » Getting to a 3.1.1 release
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented 
Autoloading hooks in the file (modules/views_url_alias/views_url_alias.views.inc) is deprecated in drupal:11.2.0 and is removed from drupal:12.0.0. Move the functions in this file to either the .module file or other appropriate location. See https://www.drupal.org/node/3489765

The referenced CR has the simple fix as moving these functions to the .module file. That seems appropriate for the scope of this issue.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

Added a simple functional test that installs the module and verifies the settings page loads. Test passes in D10 and D11.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Status: Active » Needs review
Related issues: +#3417436: Call to deprecated function watchdog_exception(), +#3432869: Fix the cspell and phpstan issues , +#3433027: Database Indexes was never created because incorrect key in hook_schema, +#3396154: D10 - Status Report primary key not set for views_url_alias, +#3535598: ResourceNotFoundException breaks table rebuild, +#3435552: Automated Drupal 11 compatibility fixes for views_url_alias
gold’s picture

gold
they/them
Location 20 minutes in the future
commented

I'm very keen to get this landed as well.

This project doesn't appear to have a composer.json file though. I do my testing of MRs that touch the core_version_requirement for D11 compatibility by adding the project to the repositories and pulling that using composer. Without that composer.json though, it's not pulling the repo.

gold@ackama:~/Projects/site-drupal (main)$ composer require 'drupal/views_alias_filter:e4db1e43786dab51888c5320581206394f738
cb0'

In VcsRepository.php line 422:
                                                                                                                                
  No valid composer.json was found in any branch or tag of https://git.drupalcode.org/project/views_url_alias.git, could not l  
  oad a package from it.                                                                                                        
                                                                                                                                

require [--dev] [--dry-run] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--fixed] [--no-suggest] [--no-progress] [--no-update] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--update-no-dev] [-w|--update-with-dependencies] [-W|--update-with-all-dependencies] [--with-dependencies] [--with-all-dependencies] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-m|--minimal-changes] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--] [<packages>...]

What am I missing? Is there another process for checking out an MR for projects without a composer.json?

gold’s picture

gold
they/them
Location 20 minutes in the future
commented
Status: Needs review » Reviewed & tested by the community

Ended up checkout out the repo locally and testing that way.

Followed the very brief 2-step guide in the README to enable this on the /admin/content View. Added multiple nodes with various URL aliases. Filtering on the path works for me.

This is working as advertised on 10.5.4 and 11.2.5.

I'd consider this RTBC.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Status: Reviewed & tested by the community » Needs review

Added the composer.json noted in #7

manuel garcia’s picture

manuel garcia commented

Re: https://git.drupalcode.org/project/views_url_alias/-/merge_requests/36/d...

Should we drop compatibility with D8 and 9? Late-upgraders will need to upgrade to D10 before going to D11 anyway.

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented

Doing a little tidy on last couple of issues and yes, I plan to make a release

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

okay, happy with the MR

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented

Should we drop compatibility with D8 and 9? Late-upgraders will need to upgrade to D10 before going to D11 anyway.

I’m not against doing that but it would be a “breaking change” and, therefore, 4.x release in my mind.

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented

Merged the MR but keeping ticket open until I’ve made a release...

rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented

Urgh - curse this half-way house of drupal/gitlab - I pressed Merge without manually adding in the merge commit message from the contribution record. Now trying to decide if I want to do a git commit --amend && git push --force

  • 7ff08b92 committed on 3.x 
    feat: #3549850 Getting to a 3.1.1 release

By: fathershawn
By: gold
By:...
rachel_norfolk’s picture

rachel_norfolk
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

I think we can mark this closed now. Thanks all!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.