Problem/Motivation

This is a follow-up issue to #3453071: Allow to use referenced entity fields as a caption source, which allows referenced entity fields to be used as caption source. Now, potentially we could also add support to allow tokens only existing on the referenced entity to be valid caption source.

Steps to reproduce

Proposed resolution

Allow to use referenced entity's tokens as caption source

Remaining tasks

  1. Check how the token / token key should be named identically to similar cases in core / contrib
  2. Implement the token for the reference
  3. Test
  4. Release

User interface changes

API changes

Data model changes

Issue fork photoswipe-3548372

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Category: Task » Feature request
Issue summary: View changes

Thanks @grevil!

If someone needs this, please implement a MR for review and please first see the "Remaining tasks" here as it's important to use a consistent naming for the token reference key.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Category: Feature request » Bug report
Priority: Minor » Normal

WE need this xD

For the regular [media:X] case in a node.

Marking this as BUG because the token browser already shows [media:X] correctly but it does not work.

grevil opened merge request !166

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Needs review

Please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
Status: Needs review » Needs work
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » Unassigned
Status: Needs work » Reviewed & tested by the community

Great! RTBC

  • anybody committed c65dc3c9 on 5.x authored by grevil 
    fix: #3548372 Photoswipe Caption: Allow to use referenced entity's...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.