Problem/Motivation

Drupal 10 sites which have already updated to Commerce 3.2.0 are currently unable to update this module. The 8.x-1.x branch has just been made incompatible, and the 2.x branch is Drupal 11 only.

Other module compatibility is preventing upgrading to Drupal 11.

This may not be possible, at which point this issue would be closed.

Steps to reproduce

From a Drupal 10.5.3 site running Commerce 3.2.0, attempt to update this module. Module requires Drupal 11 which is not possible at this stage due to limits from other modules.

Proposed resolution

Add Drupal 10 compatibility to the 2.x branch - there does not appear to be anything uniquely Drupal 11 only in the code base. If there is anything, see if BC can be added to not impact the new branch.

Remaining tasks

  • Add Drupal 10.3 to the core version requirement, matching Commerce 3.x
  • Run tests
  • Fix any issues if possible
  • Review
  • Merge

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork commerce_currency_resolver-3548343

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

elc created an issue. See original summary.

elc opened merge request !11

elc’s picture

elc commented
Assigned: elc » Unassigned
Status: Active » Needs review

Tests all happy with Drupal 10.3 minimum, but test is actually running on 10.5.3 + PHP 8.1.x.

The only change of significance is the removal of string typing on consts in the CurrencyResolverManagerInterface. Not having typing in there does not impact the functionality of the module.

Overriding TypedConfigManagerInterface using constructor property promotion when it is already in the parent needed a clean up.

Making the 2.x branch Drupal 10 compatible is a success. This matches it up to Commerce Core compatibility of the 3.2.x branch.

elc changed the visibility of the branch 2.0.x-3548343-D10-support to hidden.

elc changed the visibility of the branch 2.0.x-3548343-D10-support to active.

elc’s picture

elc commented

Sorry, I misclicked the hide branch button and it doesn't confirm.

valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Status: Needs review » Reviewed & tested by the community

I did want to not support D10 intentionally but could not time the release with 3.2 exactly, so probably people had made an upgrade to 3.2 with D10

And you did invest effort already, so why not :-D

valic’s picture

valic
Primary language Croatian
Location Osijek
commented

Annoying with the JS test, random failures.

But they are passing so will merge. but against 2.x, than 2.0.x and tag a release

{"sessionId":"041ae45357533bb671bb767caa911d82","status":10,"value":{"message":"stale element reference: stale element not found in the current frame\n  (Session info: chrome-headless-shell=123.0.6312.58)\n  (Driver info: chromedriver=123.0.6312.58 (6b4b19e9dfbb93aa414dc045bd445287977d8d7a-refs/branch-heads/6312_46@{#3}),platform=Linux 5.10.242-239.961.amzn2.x86_64 x86_64)"}}

  • valic committed f6d861ce on 2.x authored by elc 
    [#3548343] Add Drupal 10 support.

  • valic committed f6d861ce on 2.0.x authored by elc 
    [#3548343] Add Drupal 10 support.
valic’s picture

valic
Primary language Croatian
Location Osijek
commented
Status: Reviewed & tested by the community » Fixed

tagged new release, tnx
https://www.drupal.org/project/commerce_currency_resolver/releases/2.0.1

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

elc’s picture

elc commented

Thank you for the speedy release!

Sorry I ruined your plans for D11 only. I would think dropping supported Drupal Cores should be lined up with Commerce anyway as it currently supports 10.3 too? Otherwise there is a hole in the supported releases exactly for those Drupal 10.5.x sites running Commerce 3.2.0 simply could not use this module (now fixed). A lot of sites are not allowed to stay on old versions of modules for certification, and even must use only stable releases.

The release versioning on Commerce is a little unexpected at present - 3.1.x is marked as support but it is no longer receiving patches (seemingly) - everyone should be using 3.2.x instead. 3.1.x has this bug in it: #3542545: Include Attribute deriver class parameter Without that patched into 3.1.x, it will WSOD on any supporting module that uses the new plugin Attributes and a deriver for about half of the plugin types of Commerce. I would assume that at some point 3.1.x will be marked as unsupported, meaning Drupal 10 sites will need to be running the latest Commerce 3.x branch. I think the point I'm trying to say is that Drupal 10 support on Commerce supporting modules is important while Commerce supports it.

Yes, the random test failure was a pain as I didn't initially realise is was it a random failure. I couldn't reproduce it locally

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.