Problem/Motivation

Module is not compatible with php 8.4 and throwing warning

Steps to reproduce

Deprecated: Drupal\custom_pub\Plugin\Action\SetCustomPublishOptionValue::access(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead i
n custom_pub/src/Plugin/Action/SetCustomPublishOptionValue.php on line 82

Proposed resolution

Fix PHP code for 8.4 compatibility

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork custom_pub-3541584

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

daniel korte created an issue. See original summary.

daniel korte opened merge request !9

daniel korte’s picture

daniel korte
he/him/his
Primary language English
Location Brooklyn, NY
commented
Assigned: daniel korte » Unassigned
Status: Active » Needs review
pahles’s picture

pahles commented

The description of the MR is probably meant for another issue? Anyway this MR will fix the PHP 8.4 compatibility issue and remove the deprecation warning.

fizcs3’s picture

fizcs3 commented
Status: Needs review » Reviewed & tested by the community

I applied a patch of MR!9 to custom_pub version 1.1 on D10.6.5 with PHP 8.4, and I agree with #4 that it does appear to fix the issue.
Moving to RTBC.