Overview
E2E tests are missing in XB AI and it should be implemented to reduces chances of regression after updates or refactoring.
Proposed resolution
User interface changes
Issue fork experience_builder-3539554
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
narendrarI have added tests and it is ready for review. However it is blocked on #3538439: Running tests locally is difficult to match with the CI
Comment #4
narendrarThe blocker has been resolved. I have rebased with the latest changes, and this issue is now ready for review.
Comment #5
yautja_cetanu commentedComment #6
yautja_cetanu commentedPossibly a follow up issue.
Comment #7
kunal.sachdev commentedThis provides a good foundation!! We can include additional tests for page builder tasks and other cases in a follow-up.
Comment #8
kunal.sachdev commentedFollow-up issue created #3542219: Expand Playwright test coverage for XB AI module
Comment #11
tim.plunkettMerged into 1.x! Not backporting because #3538439: Running tests locally is difficult to match with the CI wasn't backported.
Comment #12
wim leersThis caused a regression on
1.x: it is a new flaky test.I've now seen these new tests fail in multiple MRs, always like this:
— https://git.drupalcode.org/project/experience_builder/-/jobs/6274833#L1337
While it's still fresh in your head, please harden this 🙏
Comment #13
wim leersAlso, many more failures from this new test coverage in https://git.drupalcode.org/project/experience_builder/-/jobs/6275720 (4 of the 6 failures!) — although maybe those failures are caused by the changes in that MR, although I really don't see how.
I'll re-test it (queued: https://git.drupalcode.org/project/experience_builder/-/jobs/6275778), but would very much appreciate you manually testing the AI functionality with that MR checked out. 🙏
Comment #18
jessebaker commentedComment #19
wim leersMuch appreciated, @NarendraR, @justafish and @jessebaker! 😊🙏
Comment #20
jvbrian commentedjvbrian I deleted my push because I accidentally created my test file in the wrong issue. Since I’m creating new Playwright tests, they should be in issue #3537161.