Overview

Code components have a metadata file that mimics that of SDCs. The download command incorrectly creates this metadata file, saving props: [...] instead of props.properties: [...].

Proposed resolution

Fix the download command, and introduce type checking for the component metadata.

Issue fork experience_builder-3539282

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

balintbrews created an issue. See original summary.

balintbrews credited amangrover90.

balintbrews credited ankithashetty.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented

Adding credit for reporting the issue and investigating the problem.

balintbrews opened merge request !1403

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Assigned: balintbrews » hooroomoo
Status: Active » Needs review

Important note: While this is targeting the 1.x branch, due to #3538775: Handle data dependencies in CLI commands, validate CLI test fixtures against OpenAPI spec, it needs to be tested with an XB module installation from the 0.x branch. Backporting code of the CLI tool has no practical benefit since it's a separate release process, but this is a bit inconvenient until we fix #3538775: Handle data dependencies in CLI commands, validate CLI test fixtures against OpenAPI spec.

  • balintbrews committed 10f62206 on 1.x 
    Issue #3539282 by balintbrews, amangrover90, ankithashetty, hooroomoo:...

balintbrews credited hooroomoo.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Assigned: hooroomoo » balintbrews
Status: Needs review » Patch (to be ported)

I might have been wrong in #6, and we may need to backport anyway and start branching with the CLI tool versions.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented
Assigned: balintbrews » Unassigned
Status: Patch (to be ported) » Fixed

#9 — No, we can avoid that, see #3538775-4: Handle data dependencies in CLI commands, validate CLI test fixtures against OpenAPI spec.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.