Problem/Motivation

The import button overrides every field in a config page without asking for a confirmation.
This makes it easy to click it by accident.

Also if no context is selected, it will simply clear every field.

Steps to reproduce

Create a config page on a multilingual site and enable Language context.
Browse to the edit form, fill the fields and save.
Browse to the edit form and click Import: the fields are now empty.

Proposed resolution

It should ask for a confirmation, similar to the "Clear values" button.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork config_pages-3539074

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

shumer made their first commit to this issue’s fork.

shumer opened merge request !54

shumer’s picture

shumer commented
Assigned: Unassigned » shumer
Status: Active » Needs review
miritas’s picture

miritas commented
Status: Needs review » Reviewed & tested by the community

Work as expected. Looks good to me.

  • 15c21516 committed on 8.x-2.x 
    Issue #3539074 by shumer: Import feature does not ask for confirmation
shumer’s picture

shumer commented
shumer’s picture

shumer commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.