Problem/Motivation

Thestr_replace in the class OEmbedIframeController.php attempts to replace the URL in the markup but in the case of using the example below as Vimeo-link there is an extra &app_id=122963 in the markup which does not match the new url.

Steps to reproduce

  • Add the Vimeo-link to the media library
  • Enable the field display options: Autoplay video and Embed as background video

Proposed resolution

Make a consistent approach that handles both encoded and unencoded URLs.

Issue fork media_oembed_control-3535170

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 2.x Comparechanges, plain diff MR !6
About issue forks

Comments

coretex created an issue. See original summary.

coretex’s picture

coretex commented
Assigned: Unassigned » coretex
coretex’s picture

coretex commented
Issue summary: View changes

coretex opened merge request !6

coretex’s picture

coretex commented
Status: Active » Needs review
coretex’s picture

coretex commented
Assigned: coretex » Unassigned

  • jacobbell84 committed 42a27952 on 2.x authored by coretex 
    Issue #3535170: handle both encoded and unencoded URLs in oEmbed iframe...
jacobbell84’s picture

jacobbell84 commented
Status: Needs review » Fixed

Thank you!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.