Closed (fixed)
Project:
Piwik PRO
Version:
1.4.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
9 Jul 2025 at 15:01 UTC
Updated:
30 Sep 2025 at 08:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
phamnguyen commentedIgnore this patch and use the latest in comment #4
Comment #4
phamnguyen commentedComment #5
phamnguyen commentedComment #6
phamnguyen commentedComment #7
hartsak commentedThanks for the effort with this one @phamnguyen and sorry for taking so long with the reply!
I hadn't noticed your work with the issue before.
I added a few comments to the merge request.
Here are a couple of thoughts too:
Thank you!
Comment #8
phamnguyen commentedThanks for your reply.
Comment #9
phamnguyen commentedupdated patch for version 1.4.1
Comment #10
phamnguyen commentedthis one is for version 1.4.0
Comment #11
phamnguyen commentedComment #12
phamnguyen commentedComment #13
phamnguyen commentedwip
Comment #14
phamnguyen commentedComment #15
phamnguyen commentedComment #16
phamnguyen commentedfinal 1.4.1 version patch
Comment #17
phamnguyen commentedComment #18
hartsak commentedThanks for all the changes you did to the code @phamnguyen !
I think it looks good now. I tested your changes and everything seems to work.
Even though I previously said we don't want to touch unrelated parts of the module within this issue, I still kind of had to do a small change to the update hooks. They were previously added to the wrong file (.module) and you added the new hook to the correct place (.install file) so I just moved all the old hooks to the .install file, reorganized them a bit and renamed your hook so it should be consistent with the old ones.
I also liked the description texts you had added to the form, great job with those too.
I'll move this to RTBC
Comment #20
hartsak commentedThis should be now added to the latest release 1.4.2
Thanks for your contributions @phamnguyen !