Problem/Motivation

The height for the schema explorer is hard-coded at 650px, would be nicer since there's often a lot of real estate under it to have it bigger

Proposed resolution

Make it based on a vh css variable instead

Issue fork graphql-3533544

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

atowl created an issue. See original summary.

atowl opened merge request !44

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Title: Nicer height for explorer » Use viewport height rather than fixed height for GraphQL explorer
Version: 8.x-4.x-dev » 5.x-dev
Issue tags: -CSS

Will consider this for 5.x, but I need to check what this looks like and how this affects various screen sizes.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented

On my 16 inch MacBook the change is negligible.

Moving from 650px to 75vh means that this would reduce the size on screens with less viewport height than 867px. Most screens are likely bigger than this, so there'd be more space. On smaller screens having the size of the query reduce is also good to reduce the amount of scrolling.

Since the explorer has internal scroll I'm adding a minimum height of 450px at which the explorer still works correctly. At that point to use the UI you'd have to scroll both in your browser and within the explorer itself.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • kingdutch committed e6d02961 on 5.x authored by atowl 
    feat: #3533544 Allow explorer to grow to viewport height

By: atowl
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.