Problem/Motivation

The expected social auth icons (Facebook, Google, etc.) do not load, and foreach() fails because the expected array is null, this breaks the login experience and shows warnings in the logs and UI.
Missing icons

Steps to reproduce

  1. Enable one or more Social Auth modules (e.g., Social Auth Google, Facebook) along with Gin Login module.
  2. Visit the login page (/user/login) after enabling social login.
  3. Observe: Social network icons do not appear.

Proposed resolution

  • Update the varbase_auth_preprocess_login_with() function to use $variables['networks'] instead of social_networks, as per Social Auth module changes.
  • Provide a custom image path to render on UI.
  • Update the Twig template login-with.html.twig to use networks variable instead of social_networks, and fallback to the custom image path if exist.
  • This ensures the social auth isons render properly when present.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.1.0-alpha2, varbase_auth-10.1.0-alpha2

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

n.ghunaim created an issue. See original summary.

n.ghunaim’s picture

Issue summary: View changes
n.ghunaim’s picture

Issue summary: View changes
StatusFileSize
new1.57 MB
n.ghunaim’s picture

Issue summary: View changes
n.ghunaim’s picture

Issue summary: View changes
n.ghunaim’s picture

Issue summary: View changes
n.ghunaim’s picture

Issue summary: View changes

rajab natshah’s picture

Status: Active » Needs review

rajab natshah’s picture

Assigned: Unassigned » s.halawani
Issue summary: View changes
Issue tags: +varbase-10.1.0-alpha2, +varbase_auth-10.1.0-alpha2
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
StatusFileSize
new1.11 MB
rajab natshah’s picture

Assigned: s.halawani » Unassigned
Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes