Problem/Motivation
The default links.html.twig template provided seems to not render some navigation links properly. Here is an example of what the links for article comments look like currently

Bootswatch/bootstrap styles are not applied, due to missing nav-link class. Here is what it should look like in my case

Steps to reproduce
Create fresh theme from radix starterkit, create article, add comment.
Proposed resolution
It seems like src/kits/radix_starterkit/templates/navigation/links.html.twig could be patched to properly add "nav-link" class to a <span> containing the link. Currently it tries to add that clas using item.link.text_attributes.addClass('nav-link'), but .text_attributes are always null here. Also, the docblock only mentions item.text_attributes, not item.link.text_attributes. I'd propose applying the attached patch to fix this.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| radix-nav-link-patch.patch | 951 bytes | ptomulik | |
| links-desired.png | 19.61 KB | ptomulik | |
| links-actual.png | 19.45 KB | ptomulik |
Comments
Comment #2
ptomulik commentedComment #3
doxigo commentedLovely, nice fix. Applied to the dev.
Comment #5
doxigo commented