I experienced the following error:

Fatal error: Declaration of Drupal\saml_sp\SAML\SamlSPSettings::getSPMetadata($alwaysPublishEncryptionCert = false, $validUntil = null, $cacheDuration = null) must be compatible with OneLogin\Saml2\Settings::getSPMetadata($alwaysPublishEncryptionCert = false, $validUntil = null, $cacheDuration = null, $ignoreValidUntil = false) in /app/htdocs/web/modules/contrib/saml_sp/src/SAML/SamlSPSettings.php on line 22

Making the admin page for the module unusable.

This has to do with the ignoreValidUntil that has been added to the getSPMetadata function of the Settings base class.

CommentFileSizeAuthor
#4 saml_sp-3526580-3525941.patch1.23 KBajlow

Issue fork saml_sp-3526580

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yorickdv created an issue. See original summary.

yorickdv opened merge request !63

yorickdv’s picture

yorickdv commented
Assigned: yorickdv » Unassigned
Issue summary: View changes
Status: Active » Needs review

Created MR Fixing the issue

ajlow’s picture

ajlow commented
StatusFileSize
new saml_sp-3526580-3525941.patch1.23 KB

Thank you, yorickdv for the fix and merge request. Your changes fixed the issue for me.

I've made a temporary patch with your changes while we wait for your changes to be merged.

jrglasgow made their first commit to this issue’s fork.

  • jrglasgow committed 6e6fe1d2 on 4.x authored by yorickdv 
    Issue #3526580 by yorickdv, ajlow: Add $ignoreValidUntil, as onelogin...
jrglasgow’s picture

jrglasgow commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.