Currently the route for cloning a node inherits the overridden value from the Template, but not every node may have been marked as a Template, which makes the indication "Create from template ..." confusing. Could we split up the labelling amongst the two?
Do not override quick_node_clone func
Review and test.
Distinguished UI for cloning and template node creation
N/A
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | content-templates-3526579-testing.mp4 | 466.5 KB | hanan alasari |
| #4 | content_templates-clone_template_ui_labels-3526579-4.patch | 4.63 KB | baikho |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !11changes, plain diff MR !7
Comments
Comment #3
baikho commentedComment #4
baikho commentedComment #8
a.dmitriiev commentedI have opened the new MR from the same repo, but I have created the branch out of 1.0.x (of the fork repo), because it conflicts with the origin.
The branch was also rebased on the latest changes. Let's continue in that MR.
Comment #9
a.dmitriiev commentedI have also added update hook to restore quick node clone setting to its default value and make sure that 'Clone of' is not added to the title for content template form.
Comment #10
hanan alasariComment #11
hanan alasariTested MR !11 on Drupal 11.x (DXP profile, D11.1.x, PHP 8.3)
Automated tests (7/7 pass):
- Template list page shows all templates
- Template tab appears on source node
- /template/{node}/quick_clone shows "Create from template [title]" — no "Clone of" prefix
- /clone/{node}/quick_clone still shows "Clone of [title]" — default behavior preserved
- Template picker links now use /template/{node}/quick_clone (not the old quick_node_clone route)
- "Created from" link visible on node edit form
- Delete warning when deleting a source node with templates
One observation: hook_menu_local_tasks_alter hides tabs for quick_node_clone.node.quick_clone but not for the new
content_templates.node.quick_clone route — tabs may appear when creating from a template. Worth checking if this is
intentional.
Video attached.
Comment #12
hanan alasariComment #13
hanan alasariComment #14
hanan alasariComment #15
hanan alasariAlso fixed hook_menu_local_tasks_alter to hide tabs for the new content_templates.node.quick_clone route as well — pushed to
the same branch.
Comment #16
hanan alasariComment #18
a.dmitriiev commented