Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
As i worked on Issue 3394957 I recognized, that the form fields for the stop condition of the scheduled newsletter could be improved.
- the maximum number of editions is not a number form field
- the maximum number of editions is not required (when stoptype is 2)
- the stop date is not required (when stoptype is 1)
Steps to reproduce
Go to scheduler tab of a newsletter edition which is a template and play around with the stop condition fields.
Proposed resolution
I propose ...
- to switch the field widget for the maximum number of editions to 'number' and set min value zu zero
- set a required condition for the maximum number of editions to be required when the stoptype is 2
- set a required condition for the stop date form field to be required when the stoptype is 1
Because of a core bug with the date time field, we might need a validate function for step 3. See
Issue fork simplenews_scheduler-3523573
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
jocowoodManual tests looking good, pipelines are happy, moving forward to "needs review"
Comment #4
goldfitI reviewed the changes and have no complaints.
Comment #6
jocowood