Nodes loose menu link when saved without menu permissions [#3523073]

Problem/Motivation

When a node already has a menu link provided, and an user who doesn't have permissions to add, or edit links for that menu, edits the node and then saves it, the menu link disappears from the menu. This is not Drupal core's behavior, if an user just has permissions to edit the content of the node, but not the menu link, it should be kept.

Steps to reproduce

1. Install simple_menu_permissions.
2. Edit a node with a menu link with an user that doesn't have permissions to manage links for that menu.
3. Save the node.
4. See the menu link is no longer on the menu.

Comment	File	Size	Author
#7	3523073_7.patch	1013 bytes	rakesh.regar
#7	after.png	205.81 KB	rakesh.regar
#7	before.png	164.11 KB	rakesh.regar

Issue fork simple_menu_permissions-3523073

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3523073-node-loses-menu-link changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

7 May 2025 at 09:21

juanolalla created an issue. See original summary.

Comment #2

juanolalla commented 7 May 2025 at 09:23

Issue summary:

View changes

Comment #3

8 May 2025 at 09:23

rakesh.regar made their first commit to this issue’s fork.

Comment #4

8 May 2025 at 09:24

rakesh.regar opened merge request !1

Comment #5

rakesh.regar

Hindi

India 🇮🇳

commented 8 May 2025 at 09:25

Status:

Active

» Needs review

Comment #6

juanolalla commented 8 May 2025 at 12:19

Status:

Needs review

» Needs work

Thanks @rakesh.regar, but didn't work. Same result.

These are the error messages (same as before) thrown after saving the node:

Warning: Undefined array key "menu_name" in token_node_menu_link_submit() (line 722 of modules/contrib/token/token.module).

token_node_menu_link_submit()
call_user_func_array() (Line: 307)
Drupal\Core\Entity\EntityForm->buildEntity() (Line: 155)
Drupal\Core\Entity\ContentEntityForm->buildEntity() (Line: 286)
Drupal\Core\Entity\EntityForm->submitForm() (Line: 145)
Drupal\Core\Entity\ContentEntityForm->submitForm()
call_user_func_array() (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers() (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm() (Line: 619)
Drupal\Core\Form\FormBuilder->processForm() (Line: 335)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 50)
Drupal\ban\BanMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Warning: Undefined array key "parent" in token_node_menu_link_submit() (line 723 of modules/contrib/token/token.module).

token_node_menu_link_submit()
call_user_func_array() (Line: 307)
Drupal\Core\Entity\EntityForm->buildEntity() (Line: 155)
Drupal\Core\Entity\ContentEntityForm->buildEntity() (Line: 286)
Drupal\Core\Entity\EntityForm->submitForm() (Line: 145)
Drupal\Core\Entity\ContentEntityForm->submitForm()
call_user_func_array() (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers() (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm() (Line: 619)
Drupal\Core\Form\FormBuilder->processForm() (Line: 335)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 50)
Drupal\ban\BanMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Warning: Undefined array key "menu_name" in _menu_ui_node_save() (line 122 of core/modules/menu_ui/menu_ui.module).

_menu_ui_node_save() (Line: 349)
menu_ui_form_node_form_submit()
call_user_func_array() (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers() (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm() (Line: 619)
Drupal\Core\Form\FormBuilder->processForm() (Line: 335)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 50)
Drupal\ban\BanMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Warning: Undefined array key "parent" in _menu_ui_node_save() (line 123 of core/modules/menu_ui/menu_ui.module).

_menu_ui_node_save() (Line: 349)
menu_ui_form_node_form_submit()
call_user_func_array() (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers() (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm() (Line: 619)
Drupal\Core\Form\FormBuilder->processForm() (Line: 335)
Drupal\Core\Form\FormBuilder->buildForm() (Line: 73)
Drupal\Core\Controller\FormController->getContentResult()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 50)
Drupal\ban\BanMiddleware->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 741)
Drupal\Core\DrupalKernel->handle() (Line: 19)

Comment #7

rakesh.regar

Hindi

India 🇮🇳

commented 8 May 2025 at 19:21

Status:

Needs work

» Needs review

Status	File	Size
new	before.png	164.11 KB
new	after.png	205.81 KB
new	3523073_7.patch	1013 bytes

Hi @juanolalla,

I'm not sure why it's not working on your end. When I tried to replicate the issue, I encountered the same errors you mentioned. However, after applying the patch, all four errors were resolved, and the menu link remained intact after saving the node.

It's possible that something was missed during the manual patching process. To help, I’m attaching the patch file along with before-and-after screenshots for reference.

Please give it another try and let me know—I've tested it in multiple scenarios and it worked as expected.

Thanks!

Comment #8

juanolalla commented 9 May 2025 at 17:31

Status:

Needs review

» Reviewed & tested by the community

Thank you @rakesh.regar, you are right, sorry, I made a mistake while testing it. It works indeed.

Comment #9

14 May 2025 at 06:21

9e034bb8 committed on 3.x

Issue #3523073 :Menu item looses link on node save.

Comment #10

ewout goosmann

Dutch

commented 14 May 2025 at 06:48

Thank you @juanolalla for reporting this issue and thank you @rakesh.regar for providing a solution. I was able to reproduce the issue myself and the changes in the MR fix the issue. The MR is merged into the new 3.0.1 release.

Comment #11

ewout goosmann

Dutch

commented 14 May 2025 at 06:48

Comment #12

ewout goosmann

Dutch

commented 14 May 2025 at 06:49

Status:

Reviewed & tested by the community

» Fixed

Comment #13

28 May 2025 at 06:49

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Nodes loose menu link when saved without menu permissions

Problem/Motivation

Steps to reproduce

Issue fork simple_menu_permissions-3523073

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

News items

Our community

Documentation

Drupal code base

Governance of community