Problem/Motivation

Site settings don't have a canonical route, yet they have a canonical link template defined in their annotation. This can safely be removed.

Proposed resolution

Remove the canonical link template.

CommentFileSizeAuthor
#10 3522947-10.patch1.21 KBdieterholvoet

Issue fork site_settings-3522947

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dieterholvoet created an issue. See original summary.

dieterholvoet opened merge request !58

dieterholvoet’s picture

dieterholvoet commented
Status: Active » Needs review
dieterholvoet’s picture

dieterholvoet commented

This indirectly fixes an issue for me where pages get stuck in an infinite loop when using the flattened site settings loader.

scott_euser made their first commit to this issue’s fork.

scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Makes sense thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

scott_euser’s picture

scott_euser commented

This may have led to a small regression but I have not been able to test and confirm yet https://www.drupal.org/project/site_settings/issues/3530506#comment-1615...

dieterholvoet’s picture

dieterholvoet commented
StatusFileSize
new 3522947-10.patch1.21 KB

Yeah, with #3530506: Restore canonical link template to fix regression issues committed and released the original issue is back. Don't have time to investigate, so here's a rebased version of the original MR of this issue.

scott_euser’s picture

scott_euser commented

Thanks, not sure what the normal process is : needs work again vs seperate issue

dieterholvoet’s picture

dieterholvoet commented

I created #3554566: Infinite recursion when autoloading is enabled.