With the way the modal works, we should be able to open it on the review step vs. on the redirect page in a fashion similar to the Stripe Payment Element integration.

CommentFileSizeAuthor
#9 3517255-9.review-step-modal.patch37.06 KBrszrama
#7 3517255-7.review-step-modal.patch34.31 KBrszrama

Issue fork commerce_affirm-3517255

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rszrama created an issue. See original summary.

vmarchuk made their first commit to this issue’s fork.

vmarchuk’s picture

vmarchuk
Primary language English
Location Rivne, UA
commented
Version: 2.0.x-dev » 2.x-dev

vmarchuk changed the visibility of the branch 3517255-open-the-affirm to hidden.

vmarchuk opened merge request !21

vmarchuk’s picture

vmarchuk
Primary language English
Location Rivne, UA
commented
Status: Active » Needs review
rszrama’s picture

rszrama commented
Status: Needs review » Needs work
StatusFileSize
new 3517255-7.review-step-modal.patch34.31 KB

I had to reroll this to accommodate changes from other merges (attached). When testing, I noticed I'd end up on the payment redirect step (e.g., /checkout/8/payment) instead of the simulated successful return from a redirect to advance my order to the checkout completion page. The payment authorization went through fine and the Payment entity was created, I just didn't end up on checkout complete.

rszrama’s picture

rszrama commented

This still appears to be missing return processing that would actually place the order.

rszrama’s picture

rszrama commented
Status: Needs work » Needs review
StatusFileSize
new 3517255-9.review-step-modal.patch37.06 KB

Full patch attached with changes to RedirectForm to copy what we do in StripePaymentElement.

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

I refined this a little bit to only directly place the order on return when the modal is being used; redirected customers will process through normal checkout flow completion. Committed!

  • rszrama committed 2843ea91 on 2.x 
    Issue #3517255 by vmarchuk, rszrama: Open the Affirm modal on the review...

rszrama changed the visibility of the branch 3517255-open-affirm-modal-review-step to hidden.

rszrama’s picture

rszrama commented

No clue how to delete the issue fork. I ended up just committing via a patch I finalized locally.

rszrama closed merge request !21

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.