Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.With the way the modal works, we should be able to open it on the review step vs. on the redirect page in a fashion similar to the Stripe Payment Element integration.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3517255-9.review-step-modal.patch | 37.06 KB | rszrama |
Issue fork commerce_affirm-3517255
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3517255-open-affirm-modal-review-step
changes, plain diff MR !21 - 3517255-open-the-affirm compare
Comments
Comment #3
vmarchukComment #6
vmarchukComment #7
rszrama commentedI had to reroll this to accommodate changes from other merges (attached). When testing, I noticed I'd end up on the payment redirect step (e.g.,
/checkout/8/payment) instead of the simulated successful return from a redirect to advance my order to the checkout completion page. The payment authorization went through fine and the Payment entity was created, I just didn't end up on checkout complete.Comment #8
rszrama commentedThis still appears to be missing return processing that would actually place the order.
Comment #9
rszrama commentedFull patch attached with changes to
RedirectFormto copy what we do inStripePaymentElement.Comment #10
rszrama commentedI refined this a little bit to only directly place the order on return when the modal is being used; redirected customers will process through normal checkout flow completion. Committed!
Comment #13
rszrama commentedNo clue how to delete the issue fork. I ended up just committing via a patch I finalized locally.