[CI] Move unit tests to a 'unit tests' stage

Related, #3485069: [CI] Spin off Drupal Components tests in a job of their own, add test coverage metrics.

We are talking about a job stage, not a child pipeline here, right?

Thanks for opening this, I was the one who suggested this in Slack. I had a bit of a tinker but I couldn't figure out the relationship between the child pipeline and the initial stage(s). Will be following this issue.

Somehow though, this will reopen the discussion from #3484966-6: Allow executing unit tests on multiple PHP images without having to duplicate unit tests across all environment combinations because then the tests results will be split in two places - the 'main' pipeline for unit tests and the children pipelines for kernel/functional/etc.

https://gitlab.com/gitlab-org/gitlab/-/issues/363019 is the upstream issue to keep watching - still no timeline there.

Blocker went in.

Here's another GitLab upstream issue to watch for child/parent pipeline relationship https://gitlab.com/groups/gitlab-org/-/epics/4019, looks like it's actively pursued.

After last mess with parent child access in Gitlab I find it bad idea to bet on getting artifacts/results from child pipeline

Agree with Andy. Might even advocate stop using child pipelines all together.

The MR is now splitting the unit tests in a stage of its own - still the new stage's jobs are set to start without waiting for the 'Lint' stage to end.

Not sure why we would remove "Unit tests" from the title here, i understand it's now in a "Unit test" stage. But lets consider;

- Running locally would mean running "Core on PHP 8.3"
- If tests fail "Core on PHP 8.3" is the title of the job.
- All other jobs are things like "PHPUnit Functional"

I'd probably opt to call them something like:

"Core Unit tests on PHP 8.3"
"Component Unit tests on PHP 8.3"

Or maybe:
"PHPUnit Unit Core (PHP 8.3)"
"PHPUnit Unit Components (PHP 8.3)"
"Unit tests: Core (PHP 8.3)"
"Unit tests: Components (PHP 8.3)"

Know this is pretty nitpicky, but we are gonna look at those a lot :)

Edit:
Other than the naming i think these changes are all good.

Let’s have opinions on the best naming from #13 before making changes.

Meanwhile, better wait for #3521541: [CI] Components tests coverage metrics differ by PHP version to get in.

For the record. I'd pick:

"Unit tests: Core (PHP 8.3)"
"Unit tests: Components (PHP 8.3)"

The MR is built on top of #3521541: [CI] Components tests coverage metrics differ by PHP version, but it's reviewable per se.

It splits the pipeline in three stages

• Lint
• Unit tests
• Tests (i.e. Build+Kernel+Functional that all require a db)

'Lint' and 'Unit tests' starts independently from each other, while 'Tests' starts when both the former ones have completed.

'Unit tests' use a parallel matrix to run multiple PHP versions, instead of individual jobs.

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Change looks great! Love that it's own thing and not mixed in with phpcs/phpstan stuff. Postponing on #3521541: [CI] Components tests coverage metrics differ by PHP version but can probably immediately RTBC after that lands.

On this.

Ready.

In just released Gitlab 18.6 https://docs.gitlab.com/ci/yaml/matrix_expressions/

I bet in a month or 2 it will be available for d-o or even GA

Going to go on a limb but I like this! Was never a fan of mixing the tests with phpcs/phpstan stuff.

Random unrelated to this but in the test stage is it possible to get the test group that has ran to appear at the top of the list vs bottom? Or even alphabetically so it would be grouped with the DEFAULT: Test-only and DEFAULT: Updated dependencies.

Agree this makes the UI much nicer. I am not sure we have any control over the ordering of the UI items like that unfortunately - probably needs an upstream issue.

Committed and pushed a4087df7327 to 11.x and 0107582db69 to 11.3.x. Thanks!

Ugh, commit message went wrong with the quotes, reverting and recommitting.