Problem/Motivation

When all extensions are sorted by priority it is hard to access them later by plugin ID.
The real usage case is when AlterableComposableSchema and specific plugin information have to be replaced.

Proposed resolution

Presave extensions' keys to access them later.

Known workarounds

Process the list of all extensions and check the plugin ID.

API changes

Replace usort with uasort in the SchemaExtensionPluginManager::sortByPriority

CommentFileSizeAuthor
#3 graphql-presave-extensions-keys-after-priority-sorting-3515245.patch1.16 KBandriy khomych

Issue fork graphql-3515245

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andriy khomych created an issue. See original summary.

andriy khomych opened merge request !31

andriy khomych’s picture

andriy khomych commented
StatusFileSize
new graphql-presave-extensions-keys-after-priority-sorting-3515245.patch1.16 KB

Attached static drupal patch.

klausi made their first commit to this issue’s fork.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs review

@Andriy: I pushed some changes to the pull request, we can improve the AlterableSchemaTest to test the actual AlterableComposableSchema class.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.