Problem/Motivation

The fix in #3511651 needs to be ported to the 2.0.x branch as CKEditor is broken in the Gin theme when 2.0.8 is installed.

Steps to reproduce

Install 2.0.8, Gin admin theme, CKEditor.

Proposed resolution

Port the one-line CSS fix to 2.0.x and tag.

Remaining tasks

  • ✅ File an issue
  • ✅ Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release autocomplete_deluxe-2.0.9

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3514334 by alexharries: Fixed for broken CSS in #3511651 needs to be ported to 2.0.x branch as this syntax error is breaking CKEditor in Gin

Issue fork autocomplete_deluxe-3514334

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexharries created an issue. See original summary.

alexgreyhead’s picture

alexgreyhead commented
Status: Active » Needs review

MR created at https://git.drupalcode.org/issue/autocomplete_deluxe-3514334/-/compare/2... - moving to "needs review".

rajab natshah’s picture

rajab natshah
he/him
commented

You are right Alex.
thanks for following up.
Please, create a new MR. I will merge it for you, and follow with a quick fix release

alexgreyhead’s picture

alexgreyhead commented

Hi Rajab, I can't see where to create an MR - normally there's a button/link somewhere but it doesn't look like I have it for some reason... ¯\_(ツ)_/¯

Sorry :-(

Alex

alexharries opened merge request !27

alexgreyhead’s picture

alexgreyhead commented

Figured it out - Drupalcode.org wasn't logged in even though it was... :-/

https://git.drupalcode.org/project/autocomplete_deluxe/-/merge_requests/27

Thanks

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Issue tags: +autocomplete_deluxe-2.0.9
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

Nice, Thanks, Alex
✅ Released autocomplete_deluxe-2.0.9

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.