Problem/Motivation
The alogin_user_settings table is missing the primary key which is required for READ COMMITTED transaction isolated level to work correctly.
Steps to reproduce
Check the alogin_schema() function in the alogin.install file, and observe no primary key defined.
This can also be seen by inspecting the database table schema after the module is installed.
Proposed resolution
Add uid as a primary key.
Remaining tasks
None.
User interface changes
None.
API changes
None.
Data model changes
None. The uid field is de-facto already used as a unique row identifier across the code. Also, adding a primary key would have a positive performance impact.
Comments
Comment #2
abrammPatch for applying via composer.json.
Comment #4
abrammComment #5
jonathandealmeida commentedHi abramm, I tested patch 3513396-2.patch on Drupal core version 10.4.4 and the uid column of alogin_user_settings table was assigned as primary key, I can confirm that this is working as expected.
Comment #7
ahmed.raza commentedPatched and available in 2.1.7
Thanks
Comment #8
abrammHi ahmed.raza,
Can you please add an issue credit?
Thanks!
Comment #9
ahmed.raza commentedCreditting: abramm at DevBranch, Drupal Ukraine Community for Evolving Web, jonathandealmeida at Zoocha
Comment #10
ahmed.raza commented