Problem/Motivation

As of https://git.drupalcode.org/project/commerce_shipping/-/commit/53d1da3ac3... we are able to modify the "There are no shipping rates available for this address." message in commerce_shipping. We should be able to do the same in commerce_cart_estimate.

Furthermore, logging an error, when there are no shipping methods available is not correct, as through the commerce conditions, there are cases, where there are no compatible shipping methods. Therefore, it is canonically allowed to have no shipping methods available.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork commerce_cart_estimate-3512001

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

grevil opened merge request !11

grevil’s picture

grevil commented
Status: Active » Needs review

Done! Please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks @grevil, looks good to me. This goes one step further instead of only making the message configurable.

So the maintainers should decide, if this is fine for them (while I think it makes sense for more flexibility and styling) or if only the message text should be configurable.

  • jsacksick committed 8a1e2fd0 on 2.x authored by grevil 
    Issue #3512001: Allow to modify the "There are no shipping rates...
jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Fixed

Thank you, merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.