Problem/Motivation

Support for object oriented hook implementations using autowired services.

Introduced in 11.1 (but supported back to 10.1 using BC layer).

Change should have no functional change to the module.

Proposed resolution

Convert existing hooks into OO hooks using backwards compatible code.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ✅ Automated unit testing coverage
  • ✅ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ✅ Performance
  • ➖ Security
  • ➖ Documentation
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Issue fork genpass-3509679

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

elc created an issue. See original summary.

elc’s picture

elc commented
Issue summary: View changes

Converted hook_help as a first step.

elc opened merge request !44

elc’s picture

elc commented
Assigned: elc » Unassigned
Issue summary: View changes
Status: Active » Needs review

Migration completed. Additional eyeballs appreciated.

  • elc committed 24b335d6 on 2.1.x 
    [#3509679] Migrate to OO hooks.
elc’s picture

elc commented
Status: Needs review » Fixed

No reviews. Making a RC for field testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.