Problem/Motivation

Drupal and Drush cite that Drush 13.x is required for Drupal 11.x. The Data Structures composer.json has a requirement on Drush 12.x.

Steps to reproduce

Try to install Drush 13.x on a site with data_structures.

Proposed resolution

Potentially support 12.x and 13.x.

Remaining tasks

Test Data Structures with D11 and Drush 13.x.

Issue fork data_structures-3507304

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joelsteidl created an issue. See original summary.

joelsteidl’s picture

joelsteidl commented

At a minimum we could adjust `composer.json`

Here is the changelog for Drush 13.0.0 https://github.com/drush-ops/drush/releases/tag/13.0.0.

{
    "name": "drupal/data_structures",
    "description": "Generators and utility classes for typed collections",
    "homepage": "https://www.drupal.org/project/data_structures",
    "license": "GPL-2.0-or-later",
    "require" : {
        "php": ">=8.1",
        "drush/drush": "^12 || ^13"
    },
    "support": {
        "issues": "https://www.drupal.org/project/issues/data_structures",
        "source": "https://git.drupalcode.org/project/data_structures"
    },
    "type": "drupal-module"
}

fathershawn made their first commit to this issue’s fork.

fathershawn opened merge request !5

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

Thanks for the prompt! I was working on #3507417: Add a sub-module that can be used if DS is present. locally without creating an issue here in the queue, which will require v13 but a release hasn't come out yet. Give a quick look at the MR - tested a generator command locally and all seems well.

joelsteidl’s picture

joelsteidl commented
Status: Active » Reviewed & tested by the community

@fathershawn

I tested your MR on a D11.x site with Drush 13.x and was able to successfully run a generate command.

The bump to PHP 8.3 and Drush 13.x in composer.json look good.

fathershawn’s picture

fathershawn
Primary language English
Location New York
commented

Thanks for confirming - merging so I can tag

  • fathershawn committed 0d463e41 on 1.0.x 
    Issue #3507304 by joelsteidl, fathershawn: Provide Drush 13.x...
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Status: Reviewed & tested by the community » Fixed
fathershawn’s picture

fathershawn
Primary language English
Location New York
commented
Version: 1.0.x-dev » 1.0.4
Status: Fixed » Closed (fixed)