Problem/Motivation

Every field on the menu link form has a description text, even if the purpose of the field is somewhat self-evident given the context. The extra text adds unnecessary visual noise.

Steps to reproduce

Navigate to /admin/structure/menu/manage/main/add

Proposed resolution

Remove description text from "Menu link title" and "Link".

Remaining tasks

User interface changes

One line of 'help' ie explanatory text is removed from the menu link form

CommentFileSizeAuthor
Screenshot 2025-01-27 at 11.41.49 AM.png290.28 KBlauriii
Screenshot 2025-01-27 at 11.32.03 AM.png297.13 KBlauriii

Issue fork drupal-3502487

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

lauriii opened merge request !11015

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

+1 on removing it and simplify this UI. The description "The text to be used for this link in the menu." is not giving any extra context on top of the field label itself "Menu link title", which is self-explanatory already. And the same for the link itself.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

I haven't checked the code, but seems simple enough to move it to RTBC anyway.

oily made their first commit to this issue’s fork.

oily’s picture

oily commented

I reviewed the MR. I noted that the new test assertion will pass before and after the removal of the description in the MR. I have added an assertion that asserts that the page does not contain the text of the description. That should fail without this MR and pass with it.

oily’s picture

oily commented

Not sure if you guys use the pipeline 'test-only' test. You have to run it manually. It is a smart test. It will only run any test code in the MR, ie it does not run the 'fix' code. That way you can see if you have effective test coverage. Effective in the sense that the test will fail if applied to 11.x branch before this MR is merged. But pass when the MR is merged into it.

oily’s picture

oily commented
Issue summary: View changes
quietone’s picture

quietone commented
Version: 11.1.x-dev » 11.x-dev
nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue summary: View changes

  • nod_ committed 74321e2f on 11.1.x 
    Issue #3502487 by lauriii, oily, ckrina: Make the menu link form less...

  • nod_ committed 8357990c on 11.x 
    Issue #3502487 by lauriii, oily, ckrina: Make the menu link form less...
nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 11.x-dev » 11.1.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

thanks for the extra test, in this case as this is a purely UI concern we do not need to make sure the text is not present. we removed it and keeping it in a test makes the string stay in the code. Kinda defeat the purpose of removing it :)

Committed and pushed 8357990ca57 to 11.x and 74321e2f21f to 11.1.x. Thanks!

nod_ closed merge request !11015

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.