Drupal 11 is out and this module should support it so that people can safetly upgrade.

CommentFileSizeAuthor
#22 gatsby-drupal-11-support-3501829-2a.patch2.41 KBtbadaczewski
#20 gatsby-drupal-11-support-3501829.patch5.99 KBtbadaczewski
#17 gatsby-drupal-11-support-3501829.patch4.55 KBtbadaczewski
#8 gatsby-drupal-11-support-3501829.patch4 KBtbadaczewski

Issue fork gatsby-3501829

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tbadaczewski created an issue. See original summary.

niharika.s made their first commit to this issue’s fork.

niharika.s changed the visibility of the branch 3501829- to hidden.

tbadaczewski’s picture

tbadaczewski commented
Issue tags: -

Are people actively maintaining this project? I don't mean maintainer open to PRs, but actually responding to issues?

This is a very important module for our web application, and not having it compatible with Drupal 11 is holding us back from upgrading.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

@tbadaczewski hey I'm still here but I wear a lot of hats
My advice would be to look to move away from Gatsby in general - the health of the Drupal project isn't the issue - the health of the Javascript project is - e.g. see https://github.com/gatsbyjs/gatsby/issues/38696

Drupal 10 is supported until mid/late 2026 so there's not as much urgency to get a D11 version out.

We have moved all our Drupal+Gatsby projects to something that isn't Gatsby so don't have any client projects where this update is pressing.

What this means is I'm happy to review MRs if things are ready but I'm unlikely to have time to dedicate to authoring them.

tbadaczewski’s picture

tbadaczewski commented

@larowlan thanks for the strait talk info, I do appreciate it. We have been looking to shift from GatsbyJS to NextJS, but we were hoping to upgrade the Drupal 10 backend to Drupal 11 first. I'm hoping that this module already supports Drupal 11, but just needs a version bump in the info file. I'll do my own testing to see what problems arise. Once again, thanks for the response.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

No worries, happy to merge stuff to unblock.

tbadaczewski’s picture

tbadaczewski commented
StatusFileSize
new gatsby-drupal-11-support-3501829.patch4 KB

I created a patch that solves the only PHP errors I had when testing this module with a Drupal 11 on a PHP 8.4 install. I also was able to install this on my current Drupal 10.4 update without any issues.

It also updates the core versions to ^11.

I'd love some feedback.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

@tbadaczewski nothing in that patch looks out of place to me, would committing this to HEAD make things easier?

tbadaczewski’s picture

tbadaczewski commented

Sorry, this is my first time submitting a patch so not sure next steps. Did you want me to commit the updated code to the 'gatsby-3501829' branch directly? I did request push access just in case.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

No sorry mate, I'm asking if I should commit this for you - would that make further improvements easier?
I'm not working on the module but I don't want to block fine folks like yourself who are

tbadaczewski’s picture

tbadaczewski commented

@larowlan Yes please! Thanks.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs work

The patch doesn't apply to 8.x-1.x - needs a reroll

tbadaczewski’s picture

tbadaczewski commented
Version: 8.x-1.0-alpha1 » 2.0.0-rc2
tbadaczewski’s picture

tbadaczewski commented

That was my fault, I always intended this issue to be in the context of the 2.0.0-X version. I updated the issue to reflect that.

Could you try again?

tbadaczewski’s picture

tbadaczewski commented
Version: 2.0.0-rc2 » 2.0.0-rc6
tbadaczewski’s picture

tbadaczewski commented
StatusFileSize
new gatsby-drupal-11-support-3501829.patch4.55 KB

This patch has been updated to also address the "drupal/upgrade_status" scan module finding of a depreciated function call.

Call to deprecated method loadRevision() of interface Drupal\Core\Entity\EntityStorageInterface. Deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.

  • larowlan committed 438c1c84 on 2.0.x 
    Issue #3501829 by tbadaczewski: Drupal 11 Support
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 2.0.0-rc6 » 2.0.x-dev
Status: Needs work » Active

Thanks I've committed and pushed that change to the 2.0.x branch

tbadaczewski’s picture

tbadaczewski commented
StatusFileSize
new gatsby-drupal-11-support-3501829.patch5.99 KB

Added two addtional PHP modifications so that the entire codebase adheres to the "NullableTypeForNullDefaultValue" standard. Without these changes you would get "Deprecated" warnings when running on PHP 8.4.X.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Can you provide just the new changes? I can't apply the current patch - thanks

tbadaczewski’s picture

tbadaczewski commented
StatusFileSize
new gatsby-drupal-11-support-3501829-2a.patch2.41 KB

Here is a patch that just has the additional changes for:

  • Deprecated loadRevision() Storage Type
  • Nullable Type For Null Default Value PHP 8.4 Warning

FYI, I've since upgrade my production site last week to Drupal 11 and this module is working great with these patches applied!

tbadaczewski’s picture

tbadaczewski commented
abhinesh’s picture

abhinesh
Primary language English
commented
Assigned: Unassigned » abhinesh
Status: Active » Reviewed & tested by the community

Tested and working fine with drupal 11.For now, I'm marking this issue as RTBC, for visibility.

abhinesh’s picture

abhinesh
Primary language English
commented
Assigned: abhinesh » Unassigned

  • larowlan committed a8db6d2f on 2.0.x 
    Issue #3501829 by tbadaczewski, larowlan: Drupal 11 Support
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Committed that to 2x thanks!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I cut a 2.0.0-rc7 tag with this

tbadaczewski’s picture

tbadaczewski commented

I'm so pumped that this made it to a release candidate! Thanks @larowlan!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

All you mate 🙌 thanks again

abhinesh’s picture

abhinesh
Primary language English
commented

Hi,
Still I see core_version_requirement: ^9 || ^10 in the info.yml that needs to be changed.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Hi @abhinesh could you open an MR for that? thanks!

abhinesh opened merge request !74

abhinesh’s picture

abhinesh
Primary language English
commented
Assigned: Unassigned » abhinesh

Hi @larowlan,
Done, waiting for the new release.

abhinesh’s picture

abhinesh
Primary language English
commented
Assigned: abhinesh » Unassigned

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Thanks, will cut another release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.