Problem/Motivation

When I uninstall easy_breadcrumb I expect to be able to reinstall it without having to delete the configuration it introduces manually.

You can actually see where this was removed inadvertently in #3161765: Missing keys in config schema by Vacho while resolving patching conflicts https://www.drupal.org/project/easy_breadcrumb/issues/3161765#comment-13...

Steps to reproduce

Install easy breadcrumb module.
Uninstall same module
Look for easy_breadcrumb.settings in your config
See it exists
Install easy breadcrumb module
See error.

Proposed resolution

Add necessary configuration from: https://git.drupalcode.org/project/easy_breadcrumb/-/commit/f4c3227a0257...

dependencies:
  module:
    - easy_breadcrumb
  enforced:
    module:
      - easy_breadcrumb

Remaining tasks

Add config dependency keys to installed config files
Add hook_post_update implementation to update existing sites configuration.
Add PHPUnit test to install, uninstall, and install the easy breadcrumb module again.

User interface changes

Users can now uninstall and reinstall easy bread crumb module from the UI, which would be previously impossible without special modules to delete config via the UI.

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

trackleft2 created an issue. See original summary.

greg boggs made their first commit to this issue’s fork.

greg boggs’s picture

Status: Active » Fixed

Wow. Thank you. Epic code :)

trackleft2’s picture

Status: Active » Needs work

My code was broken in the update FYI

this line in easy_breadcrumb.install use Drupal\Core\Update\UpdateException; should be use Drupal\Core\Utility\UpdateException;

trackleft2’s picture

Additionally the PHPUnit test says the module is failing to uninstall, which I am unable to reproduce manually.

https://git.drupalcode.org/issue/easy_breadcrumb-3501451/-/jobs/4101038#L80

greg boggs’s picture

new MR encouraged =)

trackleft2’s picture

Status: Needs work » Needs review

TIL we don't need the dependency keys after all.

Seems Drupal now uninstalls module installed config automatically.

We can keep the test, but everything else can be removed.

New merge request here: https://git.drupalcode.org/project/easy_breadcrumb/-/merge_requests/142

greg boggs’s picture

Status: Needs review » Fixed

trackleft2’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.