Problem/Motivation

After upgrading to version 10 am getting a fatal error on saving configuration form.

Steps to reproduce

  1. Enable the Search API Attachments module.
  2. Navigate to /admin/config/search/search_api_attachments.
  3. Under Extraction method, select any extraction method and fill in required fields. Then click “Submit and test extraction”. This triggers the following error: 
    Error: Call to a member function createInstance() on null
in Drupal\search_api_attachments\Form\TextExtractorFormSettings->validateForm()
(line 125 of /app/web/modules/contrib/search_api_attachments/src/Form/
TextExtractorFormSettings.php)

Proposed resolution

When the form is submitted Drupal uses a cached copy of the form state where $textExtractorPluginManager is null as the property is set to private instead of protected.

@mably mentioned this in #3474910-11: Drupal 11 Ready but it looks like it didn't make it into the MR.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork search_api_attachments-3501304

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cb_govcms created an issue. See original summary.

cb_govcms’s picture

cb_govcms commented
Issue summary: View changes

cb_govcms opened merge request !34

izus’s picture

izus commented

Thanks for this

  • izus committed febc0af0 on 9.0.x authored by cb_govcms 
    git commit -m 'Issue #3501304 by cb_govcms, izus: Error on saving...
izus’s picture

izus commented
Status: Active » Fixed
izus’s picture

izus commented
Status: Fixed » Closed (fixed)
izus’s picture

izus commented

The release 10.0.1 has this in