Problem/Motivation

Drupal 11 is released. So make this module compatible with Drupall 11.

CommentFileSizeAuthor
#9 search_api_attachments-pipeline-results-1.jpg130.98 KBmably

Issue fork search_api_attachments-3474910

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rushikesh raval created an issue. See original summary.

rushikesh raval changed the visibility of the branch 3474910--drupal-11 to hidden.

rushikesh raval opened merge request !26

rushikesh raval’s picture

rushikesh raval commented
Status: Active » Needs review

I have created merge request for making this module to Drupal 11 ready. I have successful used this module in my drupal 11

mably made their first commit to this issue’s fork.

mably opened merge request !27

mably changed the visibility of the branch 3474910-drupal11-compatibility to hidden.

mably changed the visibility of the branch 3474910-drupal11-compatibility to active.

mably’s picture

mably commented
StatusFileSize
new search_api_attachments-pipeline-results-1.jpg130.98 KB

Created a new MR (27) that passes all Gitlab CI validations 🎉

GitlabCI success

EDIT: It looks like the unit test is not really running. Don't know how to fix that.

mably’s picture

mably commented
Related issues: +#3434366: Automated Drupal 11 compatibility fixes for search_api_attachments
mably’s picture

mably commented

MR 27 has been successfully tested on Drupal 11 with the Solr Extractor.

FYI this MR also includes some small improvements.

For example the $textExtractorPluginManager property of the TextExtractorFormSettings form was not properly serialized/deserialized when the form was cached because the property was private. Setting it to protected solved the problem and allowed to do some cleaner dependency injection.

Problem and solution described here:
https://www.drupal.org/docs/drupal-apis/services-and-dependency-injectio...

If current maintainer is interested, I'm willing to help as a co-maintainer for simple maintenance tasks and issues processing.

Testing on Drupal 11

To test on Drupal 11, add the following lines to your composer.json repositories section:

  "repositories": [
    {
      "type": "vcs",
      "url": "https://git.drupalcode.org/issue/search_api_attachments-3474910.git"
    },

and then run:

composer require drupal/search_api_attachments:dev-3474910-drupal11-compatibility

mably changed the visibility of the branch 3474910-drupal11-compatibility to hidden.

mably changed the visibility of the branch 3474910-drupal11-compatibility to active.

mably’s picture

mably commented
Related issues: +#3463985: Replace already legacy value 'replace' in form #ajax method

MR 27 now includes the fix from the issue #3463985: Replace already legacy value 'replace' in form #ajax method.

dco’s picture

dco commented

Hi,
It seems that the branch is ready to merge.
Could we expect to be done soon ?
Or what is blocking the merge ?
I'm ready to help if needed...

  • mably committed cacbb9f8 on 9.0.x 
    Issue #3474910 by mably:  Drupal 11 Ready
izus’s picture

izus commented
Status: Needs review » Fixed

Thank you very much
Here it is https://www.drupal.org/project/search_api_attachments/releases/10.0.0

izus’s picture

izus commented
Status: Fixed » Closed (fixed)