Getting the following error with PHP 8.4

Deprecated: Drupal\google_tag\Entity\TagContainer::getGtmSettings(): Implicitly marking parameter $gtmid as nullable is deprecated, the explicit nullable type must be used instead in /app/web/modules/contrib/google_tag/src/Entity/TagContainer.php on line 188

CommentFileSizeAuthor
#8 3501147-MR-8.patch991 byteskiseleva.t

Issue fork google_tag-3501147

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

danharper created an issue. See original summary.

danharper opened merge request !109

dalemoore’s picture

dalemoore commented

I'm getting this error too on a server we just upgraded to 8.4. Luckily the site isn't currently live.

arkener’s picture

arkener commented
Status: Active » Reviewed & tested by the community

Applying the MR resolved this notice for me, the failing test seems to be unrelated.

phenaproxima made their first commit to this issue’s fork.

phenaproxima opened merge request !112

japerry closed merge request !109

kiseleva.t’s picture

kiseleva.t commented
StatusFileSize
new 3501147-MR-8.patch991 bytes

Exported MR into patch to use in composer.

rgpublic’s picture

rgpublic
Primary language German
Location Düsseldorf 🇩🇪 🇪🇺
commented

Could some maintainer commit this please? It's a one-character fix and necessary for PHP 8.4. Thank you :-)

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented

any chance for the merge?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

orkutmuratyilmaz’s picture

orkutmuratyilmaz
Primary language Turkish
Location İzmir
commented

Thank you @mglaman :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.