Problem/Motivation

We already switched from Annotation to Attributes, but it was for our own plugin types (PropType, Adapters, Sources).

But we forgot the other plugins (formatters...).

Proposed resolution

For each remaining plugin, check if Attributes are avaialble and do the conversion.

Issue fork ui_patterns-3500669

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

smovs’s picture

smovs commented
Assigned: Unassigned » smovs

smovs opened merge request !325

smovs’s picture

smovs commented
Assigned: smovs » Unassigned
Status: Active » Needs review

Hi team!
I refactored annotations with attributes in the ComponentFormatter and ComponentPerItemFormatter.
I set the field_types as entity_reference there but as I know these field_types are overridden in the ui_patterns_field_formatters_field_formatter_info_alter anyway.

Please review the MR.

pdureau’s picture

pdureau commented
Assigned: Unassigned » grimreaper
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » pdureau

Hi,

Not tested but reviewed. Ok for me. Was about to RTBC when I put 2 nitpicks comments for description.

@pdureau your opinion?

pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Needs review » Needs work

I was not expecting us to add description but only to convert existing, but that's interesting.

I have proposed my takes.

smovs’s picture

smovs commented
Status: Needs work » Needs review

I have updated the descriptions according to suggestions.
Please review

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » pdureau
Status: Needs review » Reviewed & tested by the community

Thanks!

  • pdureau committed a4e5432d on 2.0.x authored by smovs 
    Issue #3500669 by smovs, pdureau, grimreaper: From plugin Annotation to...
pdureau’s picture

pdureau commented
Assigned: pdureau » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.