Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Make tests pass on 6.2.x.
Issue fork webform-3500571
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #6
liam morlandTests are now passing on 6.2.x on Drupal 10.3.12, but only with one failing test commented-out. To-do list:
Comment #9
liam morlandComment #10
liam morlandI have disabled some tests. There are still test failures. These may be caused by running the tests on more recent versions of Drupal 10.
Comment #12
damienmckennaI added a missing test dependency and changed the tests to run concurrently, that allowed them to finish in ~18 minutes instead of timing out after ~30 minutes. The tests are now green.
Comment #13
liam morlandAfter committing some small changes, test are currently passing on 6.2.x, however one test assertion is still disabled. The merge request now re-enables that assertion, so the merge request fails. Adding the dependency on
jquery_ui_controlgroupdid not fix it. I think this should be fixed first then the version of Drupal that tests are run in should be advanced.Comment #14
liam morlandComment #15
damienmckennaThe dependency issue showed up when I ran all of the tests locally, maybe it was a dependency of another dependency so it was my fault it failed locally.
The fact that it's failing at 189 tests and not finishing them all suggests it's not running the tests concurrently per the _PHPUNIT_CONCURRENT setting - does the issue fork need to be updated?
Comment #16
liam morlandThey are running concurrently, but take almost the full half-hour so they could sometimes run over. It's also failing on the test assertion that is re-enabled by this merge request. See the previous test run for that failure.
Comment #17
damienmckennaOk, I see that now.
Is there normally such a variation in how long the tests take to run? When I added the _PHPUNIT_CONCURRENT line initially the tests ran in <20 minutes, now it's hitting twice that and timing out.
Comment #18
liam morlandWhen you added that, there was a whole test file that had been deleted because it was failing. That is now back in.
Comment #19
damienmckennaWebformVariantOverrideTest passes locally but fails on gitlabci. Hrm..
Comment #20
damienmckennaThe test that fails was last edited in #3255904: Remove the WebformAssertLegacyTrait, but it actually comes from #3094270: Add support for webform variants.
Comment #21
damienmckennaMy suggestion is that for now release this as-is with the test line commented out and then work on the one failing test separately, just to be able to move on.
Comment #22
liam morlandYes, that is the current state of things. Tests pass on 6.2.x but only because one test assertion is commented-out. The merge request in this issue re-enables it.
Comment #24
liam morlandI have commented-out several more tests. Tests are now passing on Drupal 10.6.3. The tests should be fixed-up so that they can be run again.