Problem/Motivation

In persistent login after version 2.2.1, the method \Drupal\persistent_login\TokenManager::createNewTokenForUser is updated, which uses \Drupal\persistent_login\RawPersistentToken::getHashedSeries to create a new token. So, to support persistent login, we need to use the new method \Drupal\persistent_login\RawPersistentToken::getHashedSeries in autologout_autologout_prevent()

Issue fork autologout-3500246

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

antonzavadski created an issue. See original summary.

antonzavadski changed the visibility of the branch 3500246-fix-persistent-login-tokens-after-security-fix to hidden.

deaom made their first commit to this issue’s fork.

deaom’s picture

Assigned: antonzavadski » Unassigned
Status: Active » Reviewed & tested by the community

I can confirm that MR works as expected, as without it, the if check is never true. Rebased branch and setting status to RTBC.

the_g_bomb’s picture

Would it be worth mentioning anywhere that this needs an up-to-date version of persistent login? Perhaps we can add the note in the README that support is offered for version 2.2.2 onwards.

Willing to accept this as is, if not, as I don't use the module myself, and I note that 2.2.2 was a security update, so anyone running a version lower than that is running an insecure version.

the_g_bomb’s picture

The other thought I have is that it would be better to consider using the validateToken() method per #3398250: Add persistent login module support D10. I can't say I am 100% confident about which is the best approach.

the_g_bomb’s picture

Status: Reviewed & tested by the community » Fixed

Merged, thank you

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.