Problem/Motivation

Deprecated: Drupal\fontawesome\Form\EditorIconDialog::buildForm(): Implicitly marking parameter $editor as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/web/modules/contrib/fontawesome/src/Form/EditorIconDialog.php on line 71

Steps to reproduce

Use PHP 8.4 and clear the cache

public function buildForm(array $form, FormStateInterface $form_state, Editor $editor = NULL) {

Proposed resolution

public function buildForm(array $form, FormStateInterface $form_state, ?Editor $editor = NULL) {

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork fontawesome-3498298

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

solideogloria created an issue. See original summary.

solideogloria’s picture

solideogloria commented
Issue summary: View changes

sourabhsisodia_ made their first commit to this issue’s fork.

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: Unassigned » sourabhsisodia_

sourabhsisodia_ opened merge request !43

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: sourabhsisodia_ » Unassigned
Status: Active » Needs review
solideogloria’s picture

solideogloria commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

truls1502 made their first commit to this issue’s fork.

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
commented
Status: Reviewed & tested by the community » Fixed

Released!

solideogloria’s picture

solideogloria commented

FYI: The release notes are missing issue credit for this issue.

solideogloria’s picture

solideogloria commented

Also, credit has not yet been assigned to users for this issue itself and should be added.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.