Before fixing the issue

before

CommentFileSizeAuthor
#8 bootstrap-cloud_patch-applied.png37.57 KBtirupati_singh
#8 bootstrap-cloud_after-fixes.png207.75 KBtirupati_singh
#8 bootstrap-cloud_before-fixes.png202.05 KBtirupati_singh
#4 After_patch.png326.5 KBsdhruvi5142
#4 Before_patch.png391.31 KBsdhruvi5142
#3 after.png107.78 KBalok_singh
before.png94.61 KBalok_singh

Issue fork bootstrap_cloud-3495635

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alok_singh created an issue. See original summary.

alok_singh opened merge request !47

alok_singh’s picture

alok_singh commented
Assigned: alok_singh » Unassigned
Status: Active » Needs review
StatusFileSize
new after.png107.78 KB

After fixing the issue.

after

sdhruvi5142’s picture

sdhruvi5142 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before_patch.png391.31 KB
new After_patch.png326.5 KB

Hi,
I've applied the MR!47 successfully for drupal core 10.3 and it is working as expected.

Steps I followed for testing:
1. Install Bootstrap Cloud on my local.
2. Created a article page with some data > Save the Page.
3. Checked the style of Read more and Add new comment.

Testing Result:
Here after applying the patch, the style of Read more and Add new comment looks proper as expected so moving to RTBC+1

Attaching Screenshots for reference
Status - PASS

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Read more and Add new comment, needs to be styled. » Fix missing styles for 'Read more' and 'Add new comment' links

@alok_singh

Thank you for your contribution.

@sdhruvi5142

Thank you for your review. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@alok_singh

Can you please rebase the MR due to the previous merge? Thanks!

tirupati_singh’s picture

tirupati_singh commented
Assigned: Unassigned » tirupati_singh

I'm rebasing the MR as there's no response from @alok_singh.

tirupati_singh’s picture

tirupati_singh commented
Assigned: tirupati_singh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new bootstrap-cloud_before-fixes.png202.05 KB
new bootstrap-cloud_after-fixes.png207.75 KB
new bootstrap-cloud_patch-applied.png37.57 KB

Hi, I've rebased the MR. Attaching the screenshots of before and after fixes of the issue for reference. Please review the changes. Additionally, I've applied the MR as a patch, and it applied cleanly without any errors. After applying the patch the changes are working fine.

Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@tirupati_singh

Thank you for the update. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

  • yas committed ec45f060 on 7.x authored by alok_singh 
    Issue #3495635 by alok_singh, tirupati_singh, sdhruvi5142, yas: Fix...

  • yas committed 25650fb3 on 6.x authored by alok_singh 
    Issue #3495635 by alok_singh, tirupati_singh, sdhruvi5142, yas: Fix...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.