To reproduce

  1. Make a Bootstrap Table view and select your options, include Responsive.
  2. Save and render the view.
  3. Note that the table is not responsive.
CommentFileSizeAuthor
#7 responsive-enabled.png40.19 KButkarsh_kumar_singh
#7 responsive-disabled.png48.92 KButkarsh_kumar_singh

Issue fork views_bootstrap-3495081

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drupgirl created an issue. See original summary.

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: Unassigned » utkarsh_kumar_singh

I am working on it.

utkarsh_kumar_singh opened merge request !49

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: utkarsh_kumar_singh » Unassigned
Status: Active » Needs review

All pipelines are green and passed. Fix the Responsive Tables are now responsive.

kul.pratap’s picture

kul.pratap commented
Status: Needs review » Needs work

@utkarsh_kumar_singh I have tested the changes but did not notice any difference before and after. Please make the necessary updates. Moving this to "Needs Work”.

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: Unassigned » utkarsh_kumar_singh

Thank you @kul.pratap for reviewing. I am working on it.

utkarsh_kumar_singh’s picture

utkarsh_kumar_singh commented
Assigned: utkarsh_kumar_singh » Unassigned
Status: Needs work » Needs review
StatusFileSize
new responsive-disabled.png48.92 KB
new responsive-enabled.png40.19 KB

Issue fixed please review.

kul.pratap’s picture

kul.pratap commented
Status: Needs review » Reviewed & tested by the community

I have tested the changes and they look good to me, after selecting a responsive option from Bootstrap settings, now the table is responsive.
So moving this to RTBC.
Thank You

  • shelane committed d1825f2d on 5.5.x 
    Issue #3495081: Responsive Tables are not responsive
shelane’s picture

shelane
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

It was indeed the case that the "responsive" variable is not getting read. It is likely due to a conflict with the views table processor. However, the proposed solution put the hard-coded style unnecessarily. With the variable changed in the preprocessor and the template, the class is added, and that class has that style setting. I appreciate the efforts though.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.