Problem/Motivation

Link generation on line 132 of tree.js does is hard coded to use '/' and produces in the wrong URL in some circumstances.

Proposed resolution

Replace with drupalSettings.path.baseUrl see system.module or Drupal.url() see drupal.js

Issue fork taxonomy_manager-3495013

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

exiled_hammer created an issue. See original summary.

exiled_hammer opened merge request !59

exiled_hammer’s picture

exiled_hammer commented
Assigned: exiled_hammer » Unassigned
exiled_hammer’s picture

exiled_hammer commented
Issue summary: View changes

exiled_hammer opened merge request !60

exiled_hammer’s picture

exiled_hammer commented

Opened an alternative MR using the JS URL function

exiled_hammer’s picture

exiled_hammer commented
Issue summary: View changes
selvira’s picture

selvira commented
Assigned: Unassigned » selvira
selvira’s picture

selvira commented

Same issue, I tested the solution on #60 and it worked nicely. I am applying it.
Thank you and best regards.

selvira’s picture

selvira commented
Status: Active » Reviewed & tested by the community
selvira’s picture

selvira commented
Assigned: selvira » Unassigned

vladimiraus changed the visibility of the branch 3495013-js-link-generation to hidden.

vladimiraus changed the visibility of the branch exiled-hammer-2.0.x-patch-3c43 to hidden.

  • vladimiraus committed 88583bca on 2.0.x 
    Issue #3495013 by exiled_hammer, selvira, vladimiraus: JS link generation
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you. Committed. 🍻

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.