Hi there,

I was trying to setup BAWstats when it started generating many errors. I wondered why that could be... it was not able to find many files!

The fact is you name one of your sub-folders 'core' and that file is NOT copied automatically with the rsync command when we use the --cvs-exclude command. That's in link with the core file generated by a crash under Unix.

I have another 60 modules and obviously all the Drupal 6.x modules and you are the only one with that problematic directory name.

Thank you for your consideration.
Alexis Wilke

Comments

AlexisWilke’s picture

AlexisWilke commented

Note that since Drupal is using CVS and has been thinking of switching to SVN, a file/folder named core is just not a good idea. These too may mishandle the file.

Thank you.
Alexis

egfrith’s picture

egfrith commented

I'm happy to change the name "core" - but what would a better name be? "engine"? Ideally I would rename the dir, which means getting drupal CVS admins involved.

AlexisWilke’s picture

AlexisWilke commented

Well... you make it hard on me now! 8-)

"core-engine" would also work. Just plain "core" is the problem. I have seen several ways around. For instance, the xmlsitemap people would have used xmlsitemap_core. The views have some generic names, more or less a repeat from Drupal Core (i.e. includes). Ubercart has a mix, straight names and uc_<name>, where uc is the abbreviation ("baw_core"?)

I guess you'll also need to fix any module_include() or similar call.

Thank you.
Alexis Wilke

egfrith’s picture

egfrith commented

Thanks for the suggestions; I've emailed the author of betterAWstats with them - ideally I like to keep in sync as much as possible with him.

egfrith’s picture

egfrith commented
Title: "wrong" name » core directory has a "bad" name

The author thinks "engine" is good. I've made a request of the Drupal webmasters: #594188: Request to rename a directory in CVS.

egfrith’s picture

egfrith commented
Status: Active » Fixed

I've now made the committed the change and changed the paths in the relevant files in includes. Thanks for your speedy contributions to this issue Alexis.

Next step: a new official release.

AlexisWilke’s picture

AlexisWilke commented

engine sounds good to me 8-)
Thank you for taking the time and effort.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

egfrith’s picture

egfrith commented

I've just committed this change again in the 7.x-1.x branch - for some reason it didn't seem to have made it to git.