Problem/Motivation

When trying to access the route bibcite_entity.keyword.settings as UID 1 or a user with the administer bibcite permission, a 403 is returned.

Steps to reproduce

  1. Install site
  2. Install bibcite_entity module
  3. Login with a user that has the permission administer bibcite
  4. Go to route bibcite_entity.keyword.settings (/admin/structure/bibcite/keyword/settings)
  5. See Access denied error

Proposed resolution

Create a custom form for this route rather than using _controller: '\Drupal\system\Controller\SystemController::systemAdminMenuBlockPage'

Remaining tasks

Create failing tests
Create an empty config form

User interface changes

API changes

Data model changes

Issue fork bibcite-3490215

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liampower created an issue. See original summary.

liampower opened merge request !35

liampower’s picture

liampower commented
Status: Active » Needs review

mark_fullmer made their first commit to this issue’s fork.

mark_fullmer opened merge request !38

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

The proposal above involves adding an empty settings form. It appears that there are no intended settings for the Bibcite Keyword entity at this point in time, so I would instead recommend removing the route/links that are erroneously referencing it. I've created a separate merge request for that.

If there is a reason that we should have an empty settings form for keyword entities, please explain!

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Title: Route bibcite_entity.keyword.settings access denied for user 1 » Route bibcite_entity.keyword.settings does not exist
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Version: 3.0.0-beta4 » 3.0.x-dev
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.