Problem/Motivation

Drupal\tome_static\StaticCache added two new params to its constructor. This leads to TypeError: Drupal\preview_site\PreviewSiteCache::__construct(): Argument #3 ($inner) must be of type Drupal\tome_static\StaticCacheInterface, Drupal\Component\Serialization\PhpSerialize given.

Steps to reproduce

Proposed resolution

  • Release version 1.1.11 that has a conflict on drupal/tome:1.13.0
  • Update PreviewSiteCache to be compatible with StaticCache
  • Add a dependency on drupal/tome:^1.13
  • Release version 1.2.0 (or 1.1.12?)

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork preview_site-3489505

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !19

mstrelan opened merge request !20

mstrelan’s picture

mstrelan commented
Status: Active » Needs review

Failing tests are unrelated

larowlan made their first commit to this issue’s fork.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Needs work

The test fails are related to D11 compat. So I'd be keen to resolve them here in MR20 so that we can release a real D11 version if possible
I've released 1.1.11 and merged MR 19

mstrelan’s picture

mstrelan commented

I'm not sure about that, it seems to be failing in the same way for previous major which is on Drupal 10.3.9.

acbramley’s picture

acbramley commented
Status: Needs work » Closed (outdated)

Fixed in #3433978: Automated Drupal 11 compatibility fixes for preview_site

acbramley closed merge request !20