Problem/Motivation
The drupal.tabledrag.ajax library entry is currently:
drupal.tabledrag.ajax:
version: VERSION
js:
misc/tabledrag-ajax.js: { }
dependencies:
- core/ajax
- core/tabledrag
Both dependencies do not exist. Possibly they're supposed to be core/drupal.ajax and core/drupal.tabledrag instead.
I suspect this hasn't been surfaced as an issue because ajax and tabledrag would always already be loaded on a page that uses this library, but still we should fix it.
Steps to reproduce
Proposed resolution
Change the libraries to the proper names.
Remaining tasks
TBC
User interface changes
nil
Introduced terminology
nil
API changes
nil
Data model changes
nil
Release notes snippet
N/A
Comments
Comment #2
darvanenComment #4
darvanenMR created
Comment #5
cilefen commentedThe merge is enormous. Something is wrong with the diff.
Comment #6
darvanenHoly cow, ok I'll have a look, sorry
Comment #7
darvanenTarget was wrong, sorry, should be easy to read now, just a two-line change.
Comment #8
nicxvan commentedTarget is still wrong
Comment #9
nicxvan commentedI can't edit it for some reason.
Comment #10
darvanenI'm so confused, when I open the MR it shows 14 changes, but if I use the dropdown to choose "against latest" which it already has in place, it just shows my changes.
I'll just nuke this one and start from scratch, clearly I've corrupted something.
I should be making the MR against 11.x?
Comment #11
nicxvan commentedYes 11.x
Since that is the version selected in the issue now if you click create new branch it should auto select that one to cut from.
Comment #14
darvanenAlright, that looks a lot better, thank you for the guidance.
Comment #15
nicxvan commentedYes that is what it should look like.
Comment #16
smustgrave commentedSeems pretty straight forward and obvious. Didn't find any other instances that needed to be replaced.
Comment #22
nod_Committed and pushed 1630acb886 to 11.x and 660f3bd724 to 11.1.x and 1f81a9dd69 to 10.5.x. Thanks!