Problem/Motivation

The drupal.tabledrag.ajax library entry is currently:

drupal.tabledrag.ajax:
  version: VERSION
  js:
    misc/tabledrag-ajax.js: { }
  dependencies:
    - core/ajax
    - core/tabledrag

Both dependencies do not exist. Possibly they're supposed to be core/drupal.ajax and core/drupal.tabledrag instead.

I suspect this hasn't been surfaced as an issue because ajax and tabledrag would always already be loaded on a page that uses this library, but still we should fix it.

Steps to reproduce

Proposed resolution

Change the libraries to the proper names.

Remaining tasks

TBC

User interface changes

nil

Introduced terminology

nil

API changes

nil

Data model changes

nil

Release notes snippet

N/A

Issue fork drupal-3488280

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

darvanen created an issue. See original summary.

darvanen’s picture

Issue summary: View changes

darvanen’s picture

Status: Active » Needs review

MR created

cilefen’s picture

Status: Needs review » Needs work

The merge is enormous. Something is wrong with the diff.

darvanen’s picture

Assigned: Unassigned » darvanen

Holy cow, ok I'll have a look, sorry

darvanen’s picture

Assigned: darvanen » Unassigned
Status: Needs work » Needs review

Target was wrong, sorry, should be easy to read now, just a two-line change.

nicxvan’s picture

Version: 11.1.x-dev » 11.x-dev

Target is still wrong

nicxvan’s picture

Status: Needs review » Needs work

I can't edit it for some reason.

darvanen’s picture

I'm so confused, when I open the MR it shows 14 changes, but if I use the dropdown to choose "against latest" which it already has in place, it just shows my changes.

I'll just nuke this one and start from scratch, clearly I've corrupted something.

I should be making the MR against 11.x?

nicxvan’s picture

Yes 11.x

Since that is the version selected in the issue now if you click create new branch it should auto select that one to cut from.

darvanen’s picture

Status: Needs work » Needs review

Alright, that looks a lot better, thank you for the guidance.

nicxvan’s picture

Yes that is what it should look like.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Seems pretty straight forward and obvious. Didn't find any other instances that needed to be replaced.

nod_ made their first commit to this issue’s fork.

  • nod_ committed 1f81a9dd on 10.5.x
    Issue #3488280 by darvanen, nicxvan, smustgrave: Tabledrag library...

  • nod_ committed 660f3bd7 on 11.1.x
    Issue #3488280 by darvanen, nicxvan, smustgrave: Tabledrag library...

  • nod_ committed 1630acb8 on 11.x
    Issue #3488280 by darvanen, nicxvan, smustgrave: Tabledrag library...

nod_’s picture

Version: 11.x-dev » 10.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 1630acb886 to 11.x and 660f3bd724 to 11.1.x and 1f81a9dd69 to 10.5.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.