Closed (fixed)
Project:
AUTO_INCREMENT Alter
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
16 Nov 2024 at 00:03 UTC
Updated:
8 Dec 2024 at 23:49 UTC
Jump to comment: Most recent
Comments
Comment #2
gaurav_manerkar commentedComment #4
gaurav_manerkar commentedPls review.
Thanks
Comment #5
dinarcon commentedThanks for working on this @gaurav_manerkar
Drush 11 and prior required dependency injection via a drush.services.yml file. This approach is deprecated in Drush 12+ and removed in Drush 13. See https://www.drush.org/13.x/dependency-injection/ While Drush 11 could work with Drupal 10, that version has been EOL for about a year. Let's not use services files. See https://www.drush.org/13.x/commands/ for the recommended way to author Drush commands.
Also, a few new methods are being worked on. Once the following issues land, let's add Drush commands for the methods introduced in them:
Comment #6
dinarcon commented#3487892: Get the current AUTO_INCREMENT value for one/all table(s) has landed. Let's revisit this issue.
Comment #7
gaurav_manerkar commentedUpdated drupal commands and README file.
Pls review, Thanx.
Comment #8
dinarcon commentedGreat work @gaurav_manerkar! A few things I would like to include before merging.
ignore-auto-increment-columnoption of thegetAllTableAutoIncrementValuescommand tounfiltered.getEntityList.groupingetEntityListfrom argument to option.Once the changes are implemented, let's update the README.md accordingly.
Comment #9
gaurav_manerkar commenteddone
Comment #11
baltowen commentedI tested all commands and they work as expected. @dinarcon asked to rename the
ignore-auto-increment-columnoption tounfiltered, but the actual nameonly-with-auto-increment-columnwas different from the instruction. As a suggestion it would be better to rename this option toall, since it's concise and clear to understand.Comment #13
dinarcon commentedThanks @baltowen and @gaurav_manerkar for working on this! After implementing the suggestion to use
--allas the option name, I reviewed and updated other function names and parameters. I also updated the Drush command names and included shorter aliases.