Problem/motivation

With url_embed installed, the site Status page will have the warning "Missing Facebook app credentials". If we are using other providers but do not want to use Facebook, we should be able to disable the warning.

Steps to reproduce

Visit admin/reports/status, observe Warnings section.

Proposed resolution

Allow option to disable Facebook embed and along with that, the warning.

Issue fork url_embed-3487570

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

As a maintainer, I agree that this suggestion makes a lot of sense. Perhaps the best thing to do is to move that warning to the URL Embed configuration section, instead of the generic site warnings.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

That makes sense to me. If a site builder sees that Facebook embeds do not work, they might visit the url_embed config page to find out why and see the warning there but the warning does not appear on the main status page.

gaurav gupta’s picture

gaurav gupta commented
Assigned: Unassigned » gaurav gupta

gaurav gupta opened merge request !19

gaurav gupta’s picture

gaurav gupta commented
Assigned: gaurav gupta » Unassigned
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I think it would make sense that if facebook_app_id or facebook_app_secret are provided that the url_embed_debug_facebook_access_token() check still runs. In other words, no warning if they are not configured but if they are there, they must be valid. Other than that, reading the code, it looks good.

mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Fixed
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.