Problem/Motivation

This is the dependencies section in wxt_admin.info.yml:

dependencies:
  - 'admin_toolbar:admin_toolbar'
  - 'admin_toolbar_tools:admin_toolbar_tools'
  - 'admin_toolbar_links_access_filter:admin_toolbar_links_access_filter'

All these modules are inside admin_toolbar, so it ought to be:

dependencies:
  - 'admin_toolbar:admin_toolbar'
  - 'admin_toolbar:admin_toolbar_tools'
  - 'admin_toolbar:admin_toolbar_links_access_filter'

Proposed resolution

Update the dependencies.

Remaining tasks

Implement. Check if any other modules have this problem.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 correct-dependencies-3487564-03.patch16.68 KBnilesh.addweb

Issue fork wxt-3487564

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

nilesh.addweb made their first commit to this issue’s fork.

nilesh.addweb’s picture

nilesh.addweb commented
StatusFileSize
new correct-dependencies-3487564-03.patch16.68 KB

Hi,
I have created a patch and resolved the dependency issue in other modules as well.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Related issues: +#3487561: Remove dependency on deprecated admin_toolbar_links_access_filter

@nilesh.addweb thanks for the patch! Please see related ticket; admin_toolbar_links_access_filter is deprecated and should be removed as a dependency. Can you please update your patch to remove admin_toolbar_links_access_filter? Thanks!

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I think this issue should only correct the dependencies. The other issue an take care of removing.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

This dependency:
admin_toolbar_links_access_filter

Is deprecated and should be removed.

https://git.drupalcode.org/project/admin_toolbar/-/commit/b848f6fcfc9f3b...

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

I'm going to push a patch in #3490685: wxt versions crashes on upgrades since admin_toolbar_links_access_filter is deprecated for Drupal 10.3+

liam morland opened merge request !24

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 5.3.x-dev » 6.1.x-dev
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Correct dependencies in wxt_admin » Correct dependencies
smulvih2’s picture

smulvih2
Location Canada 🍁
commented

@liam thanks for the nudge, will include this in the next release of 6.1.x.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Needs review » Fixed

The fix to the dependency name for admin_toolbar:admin_toolbar_tools has been pushed to 6.1.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I don't see a commit in the repo. Also, the merge request was fixing more than just admin_toolbar.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
Status: Fixed » Needs review

Ok I only included the change to wxt_admin module since the ticket description only talks about this. Putting back to Needs Review and will look at including the MR which has changes across many sub-modules.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@liam morland , I reviewed your diff /MR. The premise seems correct. However it could be simplified further:

For internal WxT modules, the most common/standard pattern is to just write:

dependencies:
  - wxt_ext_landing_page

Could be merged as-is, or could simplify as mentioned.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@smulvih2 , would it might be possible that this dependency improvement could help with:
#3557188: 11.2.x upgrade
?

Seeing as core Drupal 11.2.x+ may be a bit more sensitive to this than Drupal 11.1.x and previous releases?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 6.1.x-dev » 6.3.x-dev