Closed (outdated)
Project:
Hook Event Dispatcher
Version:
4.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Nov 2024 at 10:40 UTC
Updated:
9 Jan 2025 at 11:48 UTC
Jump to comment: Most recent
Comments
Comment #3
gaurav_manerkar commentedComment #4
lavanyatalwar commentedWorking on it.
Comment #5
lavanyatalwar commented@gaurav_manerkar
Done with the phpcs errors.
Comment #6
gaurav_manerkar commentedThanks @lavanyatalwar looks good.
Comment #7
cleavinjosh commentedHi @guarav_manerkar,
Thank you for creating an issue for PHP_CodeSniffer.
The issue summary should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.
Kindly update. Thank you.
Comment #8
gaurav_manerkar commentedAdded, thanks
Comment #9
gaurav_manerkar commentedComment #10
cleavinjosh commentedHi @lavanyatalwar,
Thank you for providing an MR. I applied MR!148, it was applied smoothly and fixed many phpcs issues.
These are the remaining issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml hook_event_dispatcherPlease note that there are still many issues that were not shown since it is too long.
Please check and advise.
Thank you.
Comment #11
gaurav_manerkar commentedHi @cleavinjosh,
We should also update
phpcs.xml.distfile from the module for gitlab-ci to log warninings,Comment #12
cleavinjosh commentedComment #13
cleavinjosh commentedHi @gaurav_manerkar,
I will try. Thank you.
Comment #17
cleavinjosh commentedHi @gaurav_manerkar,
My apologies, I am not sure on how to proceed.
Comment #19
gaurav_manerkar commentedHi @cleavinjosh / @lavanyatalwar,
I have updated
phpcsrules to highlight code standard errors ongitlab-ci.https://git.drupalcode.org/issue/hook_event_dispatcher-3486944/-/jobs/34...
Let me know if any of you are going to fix the remaining issues.
Thanks.
Comment #20
gaurav_manerkar commentedComment #21
lavanyatalwar commentedSure, Working on it
Comment #22
gaurav_manerkar commentedPls review.
Comment #23
el7cosmoslets wait for #3483028: Remove use-statement order sniff, and no need to change the phpcs config
Comment #24
el7cosmosClosing as #3483028: Remove use-statement order sniff landed
Comment #25
gaurav_manerkar commented@el7cosmos
There are other PHPcs issues that need to be fixed.
Comment #26
el7cosmosHEAD is now all green https://git.drupalcode.org/project/hook_event_dispatcher/-/pipelines/361694
Comment #27
gaurav_manerkar commentedPls review.
Comment #28
avpadernoSince GitLab CI is enabled for every project, that should be used to get the list of the PHP_CodeSniffer errors/warnings.
Comment #29
lavanyatalwar commentedComment #30
lavanyatalwar commented@avpaderno, Updated the issue summary
Kindly review :)
Comment #31
gaurav_manerkar commentedComment #32
gaurav_manerkar commentedUpdated issue summary.
Comment #33
el7cosmosThis is no longer needed, HEAD is already green and there are no code sniffer issues.