A recent commit (3cd91cf08edd72877636f1183bc36b6463a6056a) included in the 5.0.13 hotfix release marked a number of controller classes as "final". This obviously makes it so these controllers can not be overwritten or extended. This is not a minor change and breaks compatibility with any module that customizes the default behaviour of these controllers. Can this change please be reverted?

For example, our organization extends the Drupal\o365_sso\Controller\UserLoginController class to change the way that O365 accounts are matched to local accounts and which roles they're granted.

Comments

brownelltyler created an issue. See original summary.

  • fabianderijk committed 9c40dc5c on 5.0.x 
    Issue #3484149: Unable to override final controller classes
fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented

I didn't think about that. I reverted the change on the 4 controllers used to login/logout a user. Thos are probably the ones that are being extended in one way or another.

It's already available in the dev branch. I will create a new release soon.

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Active » Fixed
fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented

I've just released the 5.0.14 release with this fix in it

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.