Problem/Motivation

Since 2.4.0 we're not seeing any HTML output. This has been tracked down to a change to the $handler_stack in \weitzman\DrupalTestTraits\BrowserKitTrait::setupMinkSession.

Steps to reproduce

TBD, it may be specific to our setup.

Proposed resolution

Create the HandlerStack before the Client, and pass it to the Client constructor.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork dtt-3482331

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mstrelan created an issue. See original summary.

mstrelan opened merge request !17

mstrelan’s picture

mstrelan commented
Issue summary: View changes
Status: Active » Needs review

Stepping through this, it seems the $handler_stack variable has no effect, it's not attached to the client. The MR here fixes that.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Change makes sense to me

moshe weitzman’s picture

moshe weitzman commented

I wonder why tests are green even before this change.

mstrelan’s picture

mstrelan commented

Do we have any test coverage for html output? I couldn't find any.

moshe weitzman’s picture

moshe weitzman commented
Status: Reviewed & tested by the community » Fixed

Merged a while ago

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.