Problem/Motivation

The lifecycle link for the Single Directory Components (SDC) module in core/modules/single_directory_components/single_directory_components.info.yml is missing.
It should point to the appropriate section of the Deprecated and Obsolete Extensions page.


This issue focuses solely on updating the SDC link, as links for other modules were resolved in
#3445276.

Steps to reproduce

  1. Navigate to admin/modules in the current version of Drupal.
  2. Locate the Single Directory Components (Deprecated) module.
  3. Observe that there is no lifecycle link.

Proposed resolution

Update the lifecycle link for Single Directory Components in
single_directory_components.info.yml to:

https://www.drupal.org/node/3223395#s-single-directory-components-sdc.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#22 After Module.png72.88 KBsagarmohite0031
#22 Before Module.png59.64 KBsagarmohite0031
#11 3480855-nr-bot.txt8.72 KBneeds-review-queue-bot

Issue fork drupal-3480855

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mlncn created an issue. See original summary.

mlncn’s picture

mlncn commented
Version: 10.3.x-dev » 11.0.x-dev
mlncn’s picture

mlncn commented
Version: 11.0.x-dev » 10.4.x-dev

mlncn changed the visibility of the branch 3480855-deprecated-modules-that to hidden.

mlncn opened merge request !9843

mlncn’s picture

mlncn commented
Status: Active » Needs review

This merge request fixes the links. It is against 10.4.x because of course the problem is gone in 11.x— the modules are gone!

I really think that we should also change the text in the module title / description to make it clear that each "Deprecation" is really being moved into the core Help module and Drupal core systems, respectively. With any encouragement i'll take a try at wording.

Also would it be possible to have a different lifecycle than deprecated for moved or incorporated extensions?

mlncn’s picture

mlncn commented
Related issues: +#2888657: [meta] Less confusing and more consistent wording needed in module/theme add/install/update
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Test failure looks real, one of the tests looks for the SDC deprecation message.

mlncn’s picture

mlncn commented
Status: Needs work » Needs review

Thank you! Updated the test since the point is that link it is checking is wrong!

(Is there an easier way to see test failures than clicking six layers deep through the pipeline reports in code.drupal.org?)

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

(Is there an easier way to see test failures than clicking six layers deep through the pipeline reports in code.drupal.org?)

The MR on the ticket appears red if it has issue if that's what you mean. Also should receive an email if the pipeline fails.

Re-ran the nightwatch test and it was random failure.

Change makes sense also.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3480855-nr-bot.txt8.72 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

quietone commented
Title: Deprecated modules that have are incorporated into core look abandoned, especially because the anchor link from admin/modules is wrong » Update lifecycle link for sdc
Issue tags: +Bug Smash Initiative, +Needs issue summary update

This needs a rebase and an issue summary update to change the scope to just updating the link for SDC. The other were changed in #3445276: Fix lifecycle_links for deprecated or obsolete modules.

akashpj made their first commit to this issue’s fork.

Anonymous’s picture

Anonymous (not verified) commented

akulsaxena made their first commit to this issue’s fork.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

Resolved Merge conflict and rebased as requested

Anonymous’s picture

Anonymous (not verified) commented

Pipeline passed with no errors/warnings

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

for the issue summary update mentioned in #12

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Status: Needs work » Needs review

Updated Issue Summary as mentioned in #12

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes

@smustgrave
Please let me know if any more changes are required

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Comment on MR.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

Reverted the change in the help_topics.info.yml file since it was out of scope based on summary and title of the issue as mentioned in #20.
Please have a look and let me know if any more changes are required.

sagarmohite0031’s picture

sagarmohite0031 commented
StatusFileSize
new Before Module.png59.64 KB
new After Module.png72.88 KB

Hello
Tested and verified on Drupal 10.
MR applied successfully.
Adding before and after screenshot

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Still appears to be a change to help_topics

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Reviewed & tested by the community

Sorry, missed the change from '-' to '_'
Made necessary changes
Please review

Anonymous’s picture

Anonymous (not verified) commented
Status: Reviewed & tested by the community » Needs review

Moving it to NR

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs issue summary update

  • longwave committed e02f07bc on 10.3.x 
    Issue #3480855 by mlncn, akulsaxena, smustgrave: Update lifecycle link...

  • longwave committed fb7ce626 on 10.4.x 
    Issue #3480855 by mlncn, akulsaxena, smustgrave: Update lifecycle link...

  • longwave committed cb28d50b on 10.5.x 
    Issue #3480855 by mlncn, akulsaxena, smustgrave: Update lifecycle link...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 10.4.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed cb28d50b8a8 to 10.5.x and fb7ce626967 to 10.4.x and e02f07bc153 to 10.3.x. Thanks!

longwave closed merge request !9843

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.