Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork smsframework-3480559

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ivnish created an issue. See original summary.

ivnish opened merge request !19

ivnish’s picture

ivnish
he/him
commented
Assigned: ivnish » Unassigned
Status: Active » Needs review

ankitv18 made their first commit to this issue’s fork.

ivnish’s picture

ivnish
he/him
commented

I pinged @dpi in slack https://drupal.slack.com/archives/C1BMUQ9U6/p1733138202393459

ankitv18’s picture

ankitv18 commented

@ivnish Either we need to fix this failing test: https://git.drupalcode.org/issue/smsframework-3480559/-/jobs/3547201#L72 or we can skip previous major pipeline.

ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Needs work

Yes, I know. I'll try to fix it

dpi’s picture

dpi
Location Perth, Australia
commented

It seems unlikely we need all of these changes to achieve Drupal 11 compatibility?

There is no justification documented for such large changes.

Lets stick to the minimum required changes.

dpi’s picture

dpi
Location Perth, Australia
commented

I've merged Gitlab, linting, and test fixes for D10 in !20.

D10 is green, D11 is not.

I'm okay with deferring linting for now, please do not address PHPCS/PHPStan/CSpell, etc.

Except!, the two deprecation errors exposed by PHPStan should be fixed, despite having a deadline of Drupal 12. There doesn't seem to be any Drupal 11 deprecation messages exposed by PHPStan at all.

I'd appreciate if we can tear down all irrelevant parts of this MR, so what remains are the essential D11 green pieces.

ivnish’s picture

ivnish
he/him
commented
Status: Needs work » Needs review

@dpi, I removed linting code and added only 2 phpstan fixes (Drupal 12 deprecations)

dpi’s picture

dpi
Location Perth, Australia
commented

  • dpi committed 3020daa7 on 2.3.x authored by ivnish 
    Issue #3480559 by ivnish, ankitv18, dpi: Drupal 11 compatibility

  • dpi committed 96b0117d on 2.4.x 
    Issue #3480559 by ivnish, ankitv18, dpi: Drupal 11 compatibility (D11...
ivnish’s picture

ivnish
he/him
commented
Status: Needs review » Fixed
dpi’s picture

dpi
Location Perth, Australia
commented
Status: Fixed » Active

Not yet, release management not complete.

dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: Unassigned » dpi
dpi’s picture

dpi
Location Perth, Australia
commented
Assigned: dpi » Unassigned

2.3.0 and 2.4.0 published, including these changes.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.